search

StuartApp / stuart-client-js

Stuart JavaScript client
MIT License
2 stars 6 forks source link

Unable to access request headers to get stuart rate-limit headers #22

Closed luisgregson closed 4 years ago

luisgregson commented 4 years ago

Hi,

I'm trying to add some logging to my application so that i can get alerts if we're getting close to rate limits.

The Stuart API Docs advise to look for some response headers, but unfortunately the ApiResponse class don't have response headers on.

Is it possible for them to be updated so that they do?

luisgregson commented 4 years ago

I've created PR #23

JoseHervas commented 4 years ago

Hi @luisgregson your PR has been approved and merged to the project 👍

luisgregson commented 4 years ago

Hi @luisgregson your PR has been approved and merged to the project 👍

Thanks @JoseHervas 😄 I dropped a message on the PR but not sure if you've seen it. Was hoping you'd be able to add the "hacktoberfest-accepted" label to the PR so that it'll count towards my Hacktoberfest submissions 🤞 Thanks