HttpClient.performGet(resource) - Add support for URL query parameters

[KasparasMasiukas]

Some endpoints (e.g. /v2/addresses/validate) require some query string parameters. It would be convenient if HttpClient.performGet would accept an additional parameter object "params", which the performGet method would attach to the request object (field "qs" of the Request.get() options).

The method's signature could become HttpClient.performGet(resource, params), without breaking the current functionality, as the new parameter "params" would, of course, be optional.

[maximilientyc]

That would be awesome indeed! Please tell us if want to start a pull request, we will be very responsive to review it 🤓

[maximilientyc]

Otherwise we will prioritise it internally.

[KasparasMasiukas]

Sure, I am opening a pull request in a few minutes, as soon as my test passes!

[KasparasMasiukas]

I suppose I need to be declared a contributor in this repository, since I get "Access denied" errors trying to push a new branch for pull request.

[maximilientyc]

Hey @Kasparas42180 have you followed this steps to created a pull request?

• Fork and clone the repository locally. You can fork the project and clone it locally:

git clone https://github.com/<your-username-goes-here>/stuart-client-js.git

• Once your code is pushed and ready to be reviewed, you can submit a pull request.

[KasparasMasiukas]

All done!

[KasparasMasiukas]

Could you update the version and make it available on npm, please?

[maximilientyc]

doing it right now 👍

[KasparasMasiukas]

🥇

[maximilientyc]

done, version 1.1.0 published to https://www.npmjs.com/package/stuart-client-js/v/1.1.0

[KasparasMasiukas]

Thanks a lot! Going to integrate that into our systems :smiley: