StuartJO / plotSurfaceROIBoundary

Plot the boundaries of ROIs on a surface
GNU General Public License v3.0
63 stars 15 forks source link

Flat map fix #2

Open KevinAquino opened 3 years ago

KevinAquino commented 3 years ago

Hey @StuartJO the code is great! :D

it worked really well for the HCP surfaces! the only issue is that it does fall over for flat patches, I think some of the properties are violated for flattened maps!

I have made a version a little while ago for the MMP1 parcellation

https://github.com/KevinAquino/freesurferFlatVisualization

will try to incorporate those features here for a fix!

StuartJO commented 3 years ago

Cool! Can you show me an example when it doesn't work?

On Tue, 27 Oct 2020 at 16:02, Kevin M Aquino notifications@github.com wrote:

Hey @StuartJO https://github.com/StuartJO the code is great! :D

it worked really well for the HCP surfaces! the only issue is that it does fall over for flat patches, I think some of the properties are violated for flattened maps!

I have made a version a little while ago for the MMP1 parcellation

https://github.com/KevinAquino/freesurferFlatVisualization

will try to incorporate those features here for a fix!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/StuartJO/plotSurfaceROIBoundary/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AETDDNNTF6MI2LLQ4Z2H5B3SMZH5HANCNFSM4TAJONVA .

StuartJO commented 2 years ago

If anyone else is looking at this, all the boundary approaches except for 'faces' will likely fail on a flat map. This is because the code (for the other methods) assumes a border forms a complete loop and this can be violated for a flat map