StubbleOrg / Stubble

Trimmed down {{mustache}} templates in .NET
Other
405 stars 58 forks source link

Fix truthy for numeric values #52

Closed emazv72 closed 5 years ago

emazv72 commented 5 years ago

Literals for number 0 are considered falsy with with patch.

Could you please review and merge commits 943b187 and 8fef46d?

codecov[bot] commented 5 years ago

Codecov Report

Merging #52 into master will increase coverage by 0.07%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #52      +/-   ##
=========================================
+ Coverage   99.83%   99.9%   +0.07%     
=========================================
  Files          73      57      -16     
  Lines        3054    2204     -850     
=========================================
- Hits         3049    2202     -847     
+ Misses          5       2       -3
Impacted Files Coverage Δ
src/Stubble.Core/Contexts/Context.cs 100% <100%> (ø) :arrow_up:
...le.Compilation/Settings/CompilerSettingsBuilder.cs
...n/Renderers/TokenRenderers/SectionTokenRenderer.cs
...ubble.Compilation/Renderers/CompilationRenderer.cs
...c/Stubble.Compilation/Settings/CompilerSettings.cs
...n/Renderers/TokenRenderers/LiteralTokenRenderer.cs
.../Stubble.Compilation/Class/EnumerationConverter.cs
...n/Renderers/TokenRenderers/PartialTokenRenderer.cs
...ion/Renderers/PartialLambdaExpressionDefinition.cs
...rc/Stubble.Compilation/Settings/DefaultSettings.cs
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update efc6b3d...8fef46d. Read the comment docs.

Romanx commented 5 years ago

Thank you very much for you contribution