Closed Tasteful closed 5 years ago
Merging #58 into master will decrease coverage by
0.76%
. The diff coverage is45.45%
.
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 97.31% 96.55% -0.77%
==========================================
Files 73 57 -16
Lines 2012 1450 -562
==========================================
- Hits 1958 1400 -558
+ Misses 54 50 -4
Impacted Files | Coverage Δ | |
---|---|---|
...c/Stubble.Core/Settings/RendererSettingsBuilder.cs | 94.59% <100%> (ø) |
:arrow_up: |
src/Stubble.Core/Settings/BaseSettingsBuilder.cs | 97.14% <100%> (-2.86%) |
:arrow_down: |
src/Stubble.Core/Builders/ParserPipelineBuilder.cs | 85.29% <14.28%> (-8.15%) |
:arrow_down: |
...derer/TokenRenderers/InterpolationTokenRenderer.cs | 100% <0%> (ø) |
:arrow_up: |
...ingRenderer/TokenRenderers/SectionTokenRenderer.cs | 100% <0%> (ø) |
:arrow_up: |
...n/Renderers/TokenRenderers/SectionTokenRenderer.cs | ||
...ubble.Compilation/Renderers/CompilationRenderer.cs | ||
...c/Stubble.Compilation/Settings/CompilerSettings.cs | ||
...n/Renderers/TokenRenderers/LiteralTokenRenderer.cs | ||
.../Stubble.Compilation/Class/EnumerationConverter.cs | ||
... and 11 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b44dd9c...f5a7666. Read the comment docs.
Hey @Tasteful,
Sorry for the delay on this one, i've been a bit busy. I made a minor change to revert the interface on the ParserPipelineBuilder since i'm not a fan of abstracting something that there will likely be only one implementation of.
Besides that i'm very happy with the contribution and look to get this released shortly! Thanks very much
This PR is for #56 and contains
BaseSettingsBuilder.ConfigureParserPipeline
method that will allow developer to easy configure the parser pipeline.Not sure how this project usually handle deprecation:
Stubble.Core.Settings.IParserPipelineBuilder
is added to only expose the methods that should be used fromStubble.Core.Builders.ParserPipelineBuilder
during the configuration.