Fix for #2 - Command palette hang when no git repository exists in project's directory hierarchy

Stubbs / sublime-vagrant

Vagrant commands for Sublime Text

43 stars 4 forks source link

Fix for #2 - Command palette hang when no git repository exists in project's directory hierarchy #5

Closed adamjgray closed 11 years ago

adamjgray commented 11 years ago

Looks like you just missed the "did I reach the root directory without finding anything" checks in a couple places. So, I just copied the code from the place that had it to the two that were missing it. This seems to fix the issue.

Stubbs commented 11 years ago

I think what actually needs to happen is that the getVagrantConfigPath methods need removing from VagrantInit & VagrantBaseCommand. The implementation on VagrantBaseCommand is redundant and should never be called, the other overrides the implementation from Vagrant class, which is what is causing this bug.

adamjgray commented 11 years ago

The implementation in VagrantBaseCommand right now is used to determine whether the commands other than vagrant init are enabled. Removing that one results in no other vagrant commands being available.