Fence is crashing Rack - Mac OS X

[pgatt]

Hi Dieter,

Your module is crashing Rack upon selection in the module browser on Mac OS X.

Rack v 1.1.5

Log file linked below: https://www.dropbox.com/s/yhs0177c4uus1rm/log%203.txt?dl=0

log 3.txt

[Stubs42]

Hi, Do not have a Mac System to test. Did some small changes hoping it may help. Fixed the widget size and check for null with if(mode != NULL) instead of if (mode). Is there any way to get more info on what is happening on the crash ? Can you please give it another try ?

[pgatt]

No that's worse, cannot build it at all now.

c++ -std=c++11 -stdlib=libc++ -I./src -fPIC -I../../include -I../../dep/include -MMD -MP -g -O3 -march=nocona -funsafe-math-optimizations -Wall -Wextra -Wno-unused-parameter -DARCH_MAC -mmacosx-version-min=10.7 -c -o build/src/Fence.cpp.o src/Fence.cpp src/Fence.cpp:1110:3: error: use of undeclared identifier 'w' w->box.size = mm2px (Vec(26, 7)); ^ 1 error generated. make: *** [build/src/Fence.cpp.o] Error 1

[pgatt]

Happy to test it for you on Mac as you need

[Stubs42]

Sry, my fault. Compile error should be fixed now. Please use the 1.0.0 Branch for testing. Any help to find out whats going on on mac is appreciated

[pgatt]

That fixed the immediate crash upon bringing the module into Rack. It seemed to be working quite well until I hit the SHPR trigger.

Log file below again:

https://www.dropbox.com/s/f0cyqq4yzgbiqym/log%204.txt?dl=0

[pgatt]

That crash corrupted my patch and upon starting a new patch bringing a module into the rack from the module browser crashes again.

https://www.dropbox.com/s/qvas55qdieiqqrf/log%205.txt?dl=0

[Stubs42]

Did little changes in formatting the display. Can you give the 1.0.0 another try ?

[pgatt]

Still a-crashing.

https://www.dropbox.com/s/dseiokiozndnla1/log%206.txt?dl=0

[Stubs42]

Can try the following please:

add the line: return pStr; just below: *pStr = '\0'; in line 1124 This should disable display drawing. Just to check whether the problem is in cv2Str

[Stubs42]

Just tried myself and got sometimes a crash too even with the above change. I'll investigate further

[pgatt]

Hang on, I may have still been using the default branch.

[pgatt]

Still crashing after being on the 1.0.0 branch

https://www.dropbox.com/s/eamtgh9yn8ow9kc/log%207.txt?dl=0

[pgatt]

What's your email? I can send you the Mac Crash report now that it raised one.

[Stubs42]

dieter.stubler@googlemail.com

[pgatt]

Sent. Did that help?

[Stubs42]

Very Strange, happens on my Linux build also, but sporadically, so i assume an unitialized variable or a race condition.

[Stubs42]

Hi, have the following behaviour. When running Rack from my own build it crashes after adding some Fences. I'm on branch v1 'origin/v1' git status in Rack src dir is showing me: geändert: dep/glfw (neue Commits) sry my system is german. Don't now how to get rid of this git changed message. Running Rack original Rack 1.5 (not my own build) I cannot reproduce the crashed even after adding a lot of Fences. Which Rack do you use ? Own build or the offical download version ?

[Stubs42]

Hi, as mentioned I had also sporadic crashed adding Fence using my self compiled VCV Rack. Now did the following: cd src/Rack/dep make clean cd src/Rack make clean git submodule update --init --recursive make dep make after doing this I could not reproduce the crash adding Fence any more. So if you are running on a self built Rack, please check with the official release, just to make sure we are not hunting ghosts.

[pgatt]

I’m fairly sure I’m using the default downloaded Rack.

On 15 Oct 2019, at 8:58 pm, Stubs42 notifications@github.com wrote:

 Hi, as mentioned I had also sporadic crashed adding Fence using my self compiled VCV Rack. Now did the following: cd src/Rack/dep make clean cd src/Rack make clean git submodule update --init --recursive make dep make after doing this I could not reproduce the crash adding Fence any more. So if you are running on a self built Rack, please check with the official release, just to make sure we are not hunting ghosts.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[Stubs42]

Hi, after some digging I have a question. Is there a problem to call configParam in process to change the min/max and default of a knob when changing mode ?

[pgatt]

Hi Dieter,

Sorry no idea.

On 15 Oct 2019, at 11:07 pm, Stubs42 notifications@github.com wrote:

Hi, after some digging I have a question. Is there a problem to call configParam in process to change the min/max and default of a knob when changing mode ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Stubs42/OrangeLine/issues/1?email_source=notifications&email_token=AAAGIT67ALZI6T6GZ23UITTQOWXBFA5CNFSM4JAVS4OKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBIQBSY#issuecomment-542179531, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGIT62HWUVMO4IV4JSUKDQOWXBFANCNFSM4JAVS4OA.

[Stubs42]

Problem should be fixed now. calling configParam again after the constructor was executed is not allowed. Changed this according to Andrew, by just changing the existig paramQuantities member variables. There are no crashes here on my side anymore. So please give it a try once more and let me know whether it works so I can close this issue.

[pgatt]

Which branch should I try?

[Stubs42]

1.0.0 is the one to be released in plugin manager, so take this one.

[Stubs42]

Thank you for showing me this problem which was not so obvious because it worked in my environment most of the time. Now it should be fixed with your help.

[pgatt]

Yep, seems to be working completely correctly here.

[Stubs42]

Thank you for showing me this problem which was not so obvious because it worked in my environment most of the time. Now it should be fixed with your help.

[Stubs42]

After replacing calls to configParam by changing parameterQuantity member variables it now works as expected and this issue was closed