Stubs42 / OrangeLine

OrangeLine VCV Plugin
GNU General Public License v3.0
14 stars 6 forks source link

Fence crashes VCV instance in Bitwig when reopening a project. #14

Closed Torinbob closed 2 years ago

Torinbob commented 2 years ago

Hi Deiter,

I am getting an issue in Bitwig where after I quit then reopen a Bitwig project, if the rack VST patch has Fence in it, then Rack crashes on startup when I reopen the project.

Screenshot 2021-12-02 at 11 06 49

If I remove Fence from the patch, then the Rack VST loads fine on startup.

Adding Fence from the browser and using it in the patch is all working fine. The issue only happens after saving and quitting Bitwig then launching it again.

Regards, Steve

Stubs42 commented 2 years ago

Hi, I haven't tested using as VST yet. I also do not have bitwig. Since I have no idea what is causing that I need some more information on that. Which environment do you use windows/linux/mac? Is there any log file or similar giving a little hint on whats happening ? Working with FENCE on the stand alone VCV works just fine on windows. Any hint on what I can do is appreciated. Regards Dieter

Stubs42 commented 2 years ago

btw. does this happen with other orange line modules too?

Torinbob commented 2 years ago

I tested with other Orangeline modules. The crash also happens with dejavu, but all others are fine. So it is something that Fence and Dejavu have in common, but not your other modules.

In fact I do not need to quit and restart Bitwig to get the issue - I can repeat it by deleting the Rack VST instance, and then undoing. Without fence or dejavu in the patch, the undo works fine, with them, Rack immediately crashes when I undo.

I'm on Mac. I don't know about a log, I will take a look and see if I can find anything

You can get a free unlimited time demo of Bitwig if that helps. You'll like Bitwig - it's awesome!

Torinbob commented 2 years ago

Hi Dieter,

Antonio has been getting a similar crash on load and undo in the DAW with Nysthi.

He just replied to me:

"from what you are saying (crash on open, on UNDO, and let me guess, on DUPLICATE) the problem arise from a “dataFromJson”.

Does that help maybe?

cschol commented 2 years ago

The issue has been confirmed to be related to font reference storage across frames (in any module that uses custom fonts).

Please see this link on how to properly implement this and re-submit to the Library: https://vcvrack.com/manual/Migrate2#2-1-Don-t-store-Font-and-Image-references-across-multiple-frames

Stubs42 commented 2 years ago

Should be fixed now and already submitted to the library. Thanks for your help finding the cause

Stubs42 commented 2 years ago

Please let me know whether the problem is fixed after 2.3.10 is available in the plugin library, so I can close this issue.

cschol commented 2 years ago

Confirmed to not crash. Update released in Library.

Stubs42 commented 2 years ago

Thx for your support