StudentAffairsUWM / Laravel-Shibboleth-Service-Provider

Shibboleth Authentication for Laravel
https://packagist.org/packages/saitswebuwm/shibboleth
30 stars 38 forks source link

Laravel 5.4 #25

Open jpuck opened 7 years ago

jpuck commented 7 years ago

If you merge this into master, then you should bump the major version (2.0) to comply with semver because there were quite a few breaking changes that came about with 5.3 and 5.4.

Just to get started, service providers are initialized with a different method now 3366b33

With the introduction of the built-in web and api middleware routes, the session variable is only attached to the web routes (conversely api routes use tokens), so that needed to be loaded differently in 275b9ba in order for a user to stay logged in for subsequent requests.

Fixed the jwt-auth dependencies #24, including bootstrapping the aliases inside the service provider in 8a806bb

I wrote this to support multiple authentication types aside from just shib, and I noticed there was a bug when falling back to native authentication due to the type value not being set in 50fdb57

There have been some general namespacing conventions lately inside the config files, so I conformed the group_model and user model and revamped the documentation with Github-style markdown for syntax highlights.

cjmaio commented 7 years ago

Thank you for this commit! It's really appreciated. I am going to try and test this out within the next day or so, but assuming all goes well I'll be merging this in.

jpuck commented 7 years ago