search

StudentAffairsUWM / Laravel-Shibboleth-Service-Provider

Shibboleth Authentication for Laravel
https://packagist.org/packages/saitswebuwm/shibboleth
30 stars 37 forks source link

PHP Fatal error: Can't use function return value in write context #28

Open jpuck opened 7 years ago

jpuck commented 7 years ago

composer.json requires PHP >= 5.4.0 so I added that version to the environment build matrix on travis and scripted a quick lint test. It failed because of the use of a function inside empty

return (!empty(Request::server($variableName))) ?

After searching around, I discovered this wasn't supported until 5.5.

Version Description
5.5.0 empty() now supports expressions, rather than only variables.
jpuck commented 7 years ago

just realizing this doesn't matter moving forward because Laravel 5.4 requires PHP >= 5.6.4