StudentCode-in / StudentCode-in.github.io

Central Repository of Student Code-In website

https://studentcode-in.github.io/

MIT License

60 stars 62 forks source link

Fixed close popup when click outside #70

Closed andyantunes closed 4 years ago

andyantunes commented 4 years ago

Description

I added a click event in the parent element div, with a check, if true closes the popup

Fixes #68

Type of change

Please delete options that are not relevant.

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

I tested it by clicking on all popups to see if everyone was closing

[x] Click test

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules