search

StudentVue / StudentVue.js

Node.js StudentVue Library
https://www.npmjs.com/package/studentvue.js
MIT License
23 stars 7 forks source link

xml2json library is no longer maintained. use xml2js #15

Open thiccaxe opened 1 year ago

thiccaxe commented 1 year ago

xml2js also doesn't depend on libexpat, which seems need software installed on windows.

Investigating if this will change the output structure.

thiccaxe commented 1 year ago

output structure changes.

even better plan is probably to drop the dependency all together and make dependents roll their own library. The purpose of this library should be primarily dealing with the SOAP nonsense, not xml to json conversion, which is opinionated.

thiccaxe commented 1 year ago

see https://github.com/StudentVue/StudentVue.js/tree/remove-xml-parse

LoganMD commented 1 year ago

open a pr and ill gladly merge it

kaijchang commented 1 year ago

output structure changes.

even better plan is probably to drop the dependency all together and make dependents roll their own library. The purpose of this library should be primarily dealing with the SOAP nonsense, not xml to json conversion, which is opinionated.

somewhat fair, but XML is not a format usable in Javascript, JSON is literally Javascript Object Notation. best solution might to be allow user to configure the XML -> JSON converter through options on StudentVueClient like in the Python version. don't think it really makes sense to make each user do their own conversion.

thiccaxe commented 1 year ago

yep that was an idea I had. the default would be to just return the raw xml.