search

StudentVue / StudentVue.js

Node.js StudentVue Library
https://www.npmjs.com/package/studentvue.js
MIT License
23 stars 7 forks source link

Remove Soap Library Dependency #22

Closed kethan1 closed 4 months ago

kethan1 commented 5 months ago

This removes the dependency on the soap library in favor merely using a fetch request and crafting the xml through a javascript template literal. This PR also marks the login method as deprecated as all the parameters the login function takes can just be passed to StudentVueClient when creating a new instance of it for the same result.

Closes issue #14.

This also changes the indentation to 2 spaces.

kethan1 commented 4 months ago

That seems fair.

I just noticed that we didn't use much of the more advanced configuration with the soap library, though I understand that template literal may not be the way to go with this.