search

Studio-42 / elFinder

📁 Open-source file manager for web, written in JavaScript using jQuery and jQuery UI
https://studio-42.github.io/elFinder/
Other
4.64k stars 1.42k forks source link

Useless backend request during elFinder.sync() #3572

Closed nao-pon closed 1 year ago

nao-pon commented 1 year ago

Describe the bug If elFinder.sync() is called while elFinder.sync() is still running, useless backend requests will occur. This is related to #3568.

To Reproduce If the user has browser extensions installed that send a Message then this message is intercepted by js/elFinder.js:4827, and since the message is not a string of type JSON an exception is returned and the self.sync() method is called. Using the example of the wappalyzer add-on - a dozen notifications are sent at once by which elFinder sends multiple requests at once to the application backend.

Expected behavior New elFinder.sync() execution instructions should be ignored while elFinder.sync() is running.

Screenshots image

mbreliberty commented 4 months ago

Maybe this note can be useful...

There is the same problem of infinite sync loop when the "react dev tools" firefox extention is enabled... 1 full day to understand this infinite loop... but i did it !