search

Studio-42 / elFinder

📁 Open-source file manager for web, written in JavaScript using jQuery and jQuery UI
https://studio-42.github.io/elFinder/
Other
4.65k stars 1.42k forks source link

Deprecated function buttonset() #3680

Open fretzl opened 3 weeks ago

fretzl commented 3 weeks ago

With jQuery v3.7.1 and jQuery UI v1.14.0 there is this persistent warning in the browser console each time elFinder initializes:

TypeError: n.find(...).buttonset is not a function

According to the docs (https://api.jqueryui.com/buttonset/) the function buttonset() has been deprecated since jQuery UI v1.12 and should be replaced by controlgroup().

The warning is indeed fixed by replacing a few occurrences of .buttonset() with .controlgroup() in elfinder.full.js and elfinder.min.js.

dleffler commented 3 weeks ago

E.g., 2 occurrences in searchbutton.js and rename.js?

fretzl commented 3 weeks ago

No, in elfinder.full.js (lines 20426 and 31998) and consequently in elfinder.min.js

EDIT I'm referring to the official elFinder-2.1.64 release.