search

Studio-Lovelies / GG-JointJustice-Unity

It's the repo for the GGJJ Unity version! I'm too dumb to come up with a wittier description.
Mozilla Public License 2.0
7 stars 8 forks source link

Expands runtime editing to track changes to background and foreground textures #401

Closed ViMaSter closed 7 months ago

ViMaSter commented 10 months ago

Summary

Resolves #399. It's #349, but now with background and foreground sprites (and actors sandwiched in the middle).

Allows changing two sprites in-game without the need for the Unity Editor

Before/after screenshots and/or animated gif

https://github.com/Studio-Lovelies/GG-JointJustice-Unity/assets/1689033/2e74057c-7c5e-4bb7-8ef5-e57615f122be

Testing instructions

Runtime editing usage

  1. Open the main menu in the editor or start a pre-compiled binary of the game
  2. Start the game normally
  3. Press Ctrl+R
  4. Notice the system's file browser opening a directory
  5. Notice the game starting to play Script.ink inside the shown directory
  6. Change Background.png or Foreground.png and save them
  7. Notice the game automatically reloading
  8. Run all tests
  9. Check the updated wiki page

Additional information

codecov-commenter commented 10 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (abc65be) 78.33% compared to head (3d49363) 78.50%.

Files Patch % Lines
...Assets/Scripts/RuntimeEditing/FileSystemWatcher.cs 94.49% 6 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #401 +/- ## =========================================== + Coverage 78.33% 78.50% +0.16% =========================================== Files 86 86 Lines 2959 2982 +23 =========================================== + Hits 2318 2341 +23 Misses 641 641 ``` | [Flag](https://app.codecov.io/gh/Studio-Lovelies/GG-JointJustice-Unity/pull/401/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Studio-Lovelies) | Coverage Δ | | |---|---|---| | [EditModeTests_Suites_Core](https://app.codecov.io/gh/Studio-Lovelies/GG-JointJustice-Unity/pull/401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Studio-Lovelies) | `15.76% <0.00%> (-0.13%)` | :arrow_down: | | [EditModeTests_Suites_TextDecoder](https://app.codecov.io/gh/Studio-Lovelies/GG-JointJustice-Unity/pull/401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Studio-Lovelies) | `16.29% <0.00%> (-0.13%)` | :arrow_down: | | [PlayModeTests_Suites_Playthrough](https://app.codecov.io/gh/Studio-Lovelies/GG-JointJustice-Unity/pull/401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Studio-Lovelies) | `59.55% <57.79%> (+0.34%)` | :arrow_up: | | [PlayModeTests_Suites_Scenes](https://app.codecov.io/gh/Studio-Lovelies/GG-JointJustice-Unity/pull/401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Studio-Lovelies) | `56.67% <57.79%> (+0.37%)` | :arrow_up: | | [PlayModeTests_Suites_Scripts](https://app.codecov.io/gh/Studio-Lovelies/GG-JointJustice-Unity/pull/401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Studio-Lovelies) | `57.10% <94.49%> (-0.52%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Studio-Lovelies#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.