search

Studio-Lovelies / GG-JointJustice-Unity

It's the repo for the GGJJ Unity version! I'm too dumb to come up with a wittier description.
Mozilla Public License 2.0
7 stars 8 forks source link

Handle looping music, Indicate song with seamless loops in docs, automatic pre-releases #411

Open ViMaSter opened 7 months ago

ViMaSter commented 7 months ago

Summary

I'd recommend looking at the PR with these filters to focus on the important stuff: image

Before/after screenshots and/or animated gif

Songs previously only looped from start to finish. Composers can now specify loop-information: intros, loop-sections and outros.

If a song provided by the composers contains loop information, it is highlighted in the documentation:

image

Also changes the GitHub Release behavior to automatically create pre-releases whenever a build succeeds on develop.

Testing instructions

Find a song with loop markers embedded into the .ogg file. Play it and notice that the intro only is played once. Also a new GitHub pre-release should appear around 45 minutes after this is integrated into develop.

Additional information

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.98%. Comparing base (4e52fd1) to head (8bc0c1e). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #411 +/- ## =========================================== + Coverage 81.38% 81.98% +0.60% =========================================== Files 91 92 +1 Lines 3046 3148 +102 =========================================== + Hits 2479 2581 +102 Misses 567 567 ``` | [Flag](https://app.codecov.io/gh/Studio-Lovelies/GG-JointJustice-Unity/pull/411/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Studio-Lovelies) | Coverage Δ | | |---|---|---| | [EditModeTests_Suites_Core](https://app.codecov.io/gh/Studio-Lovelies/GG-JointJustice-Unity/pull/411/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Studio-Lovelies) | `14.83% <0.96%> (-0.93%)` | :arrow_down: | | [EditModeTests_Suites_TextDecoder](https://app.codecov.io/gh/Studio-Lovelies/GG-JointJustice-Unity/pull/411/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Studio-Lovelies) | `16.04% <0.00%> (-0.54%)` | :arrow_down: | | [PlayModeTests_Suites_Playthrough](https://app.codecov.io/gh/Studio-Lovelies/GG-JointJustice-Unity/pull/411/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Studio-Lovelies) | `61.30% <100.00%> (+1.29%)` | :arrow_up: | | [PlayModeTests_Suites_Scenes](https://app.codecov.io/gh/Studio-Lovelies/GG-JointJustice-Unity/pull/411/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Studio-Lovelies) | `59.37% <100.00%> (+1.36%)` | :arrow_up: | | [PlayModeTests_Suites_Scripts](https://app.codecov.io/gh/Studio-Lovelies/GG-JointJustice-Unity/pull/411/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Studio-Lovelies) | `63.97% <100.00%> (+1.20%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Studio-Lovelies#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ViMaSter commented 7 months ago

If anyone wants to review it already:

Just need to hook the Script into the ObjectPreloader and make this an active PR. 👀