Open ViMaSter opened 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.98%. Comparing base (
4e52fd1
) to head (8bc0c1e
). Report is 1 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
If anyone wants to review it already:
/unity-ggjj/Assets/Scripts/SceneLoading/LoopableMusicClip.cs
/unity-ggjj/Assets/Tests/PlayModeTests/Scripts/LoopableMusicClipTests.cs
) Just need to hook the Script into the ObjectPreloader
and make this an active PR. 👀
Summary
develop
I'd recommend looking at the PR with these filters to focus on the important stuff:![image](https://github.com/user-attachments/assets/91eef455-8dee-4258-8bc4-880f0e65cf58)
Before/after screenshots and/or animated gif
Songs previously only looped from start to finish. Composers can now specify loop-information: intros, loop-sections and outros.
If a song provided by the composers contains loop information, it is highlighted in the documentation:
Also changes the GitHub Release behavior to automatically create pre-releases whenever a build succeeds on
develop
.Testing instructions
Find a song with loop markers embedded into the
.ogg
file. Play it and notice that the intro only is played once. Also a new GitHub pre-release should appear around 45 minutes after this is integrated intodevelop
.Additional information
[ ]
Changes UI[ ]
Introduces new feature[ ]
Removes existing feature[x]
Has associated resource: