search

Studio-Lovelies / GG-JointJustice-Unity

It's the repo for the GGJJ Unity version! I'm too dumb to come up with a wittier description.
Mozilla Public License 2.0
7 stars 8 forks source link

[BUG] macOS build can't be opened on M1 Macs #420

Open ViMaSter opened 8 months ago

ViMaSter commented 8 months ago

Describe the bug

Attempting to open a .app file inside the macOS-... artefacts from any of the action runs fails by default. A workaround exists:

Steps To Reproduce + Workaround

  1. Download a macOS-... artefact from the last action run based on develop
  2. Extract it
  3. Double-click the .app file
  4. Issue 1: Notice the following error message: image
  5. Run chmod -R 777 <absolutePathToApp>/Game\ Grumps\ -\ Joint\ Justice.app
  6. Double-click the .app file
  7. Issue 2: Notice the app starting, but getting interrupted by this error message: image
  8. Right-click the .app file
  9. Select Open
  10. Notice the app starting, but getting interrupted by a different message: image
  11. Click Open
  12. The game starts

Expected behavior

  1. Download a macOS artefact from the last action runs based on develop
  2. Extract it
  3. Double-click the .app file
  4. The game starts

Additional context

I haven't verified this yet, but I've had similar issues in the past:

Issue 1: File flags

I'm pretty sure the agent running GitHub Actions defaults to different file flags. Adding a call to chmod before compressing the file should resolve this? We just need to make sure the permissions survive the .zip compression, download and extraction.

Issue 2: Missing developer certificate

Windows has a similar issue with Windows SmartScreen: image

Apple requires people to buy a certificate to ensure only "certified" developers can distribute apps.
I've recently signed up for one, because of an iOS app I was trying to distribute, so I should be able to add one to this projects build pipeline too.
If anyone else wants to work on it with their certificate, feel free! Let me know if you need help setting up the secrets on the GitHub repository.

PhoebeMitchell commented 2 months ago

There are no plans to buy a certificate from Apple, so if you did generously let us borrow yours that would be super! ❤️