[BUG] No evidence menu looks empty + exception - Githubissues

Studio-Lovelies / GG-JointJustice-Unity

It's the repo for the GGJJ Unity version! I'm too dumb to come up with a wittier description.

Mozilla Public License 2.0

7 stars 8 forks source link

[BUG] No evidence menu looks empty + exception #424

Closed ViMaSter closed 2 weeks ago

ViMaSter commented 6 months ago

Describe the bug

Using the in-game editor results in a NullReferenceException when opening the evidence menu before any evidence was added.

Steps To Reproduce

Open the in-game editor
Right after pressing Ctrl+R, press Z to open the evidence menu
Notice an exception being thrown and the menu looking fairly barren

Expected behavior

Either

we should have some form of quip ready for when there's no evidence at all
handle the NullReferenceException gracefully, if we don't ever expect to be in this state during normal gameplay

Screenshots

Additional context

Report on Sentry

PhoebeMitchell commented 3 weeks ago

For the record, this case was never implemented because there should always be at least one piece of evidence present, Arin's badge. However since it's possible to write a narrative script without the badge it's probably worth fixing.