Studio-Lovelies / GG-JointJustice-Unity

It's the repo for the GGJJ Unity version! I'm too dumb to come up with a wittier description.
Mozilla Public License 2.0
7 stars 8 forks source link

[BUG] `Dan.AirGuitar` animation advances line automatically #445

Open ViMaSter opened 1 month ago

ViMaSter commented 1 month ago

Describe the bug

This script prompts the user to press X once, which plays Dan's Guitar Animation while Dan speaks and automatically advances to Arin's line without any user input.

&SPEAK:Dan
    This is chicken on another level, Arin. First time it burned me HARD! 
&SET_POSE:AirGuitar
    I’m talking hotter than the new NSP album.

&THINK:Arin
    Ha, nice plug.

Steps To Reproduce

Additional context

Reproducible using 51fc67d64d3c6779be44e418da497ba85f671106

PhoebeMitchell commented 1 month ago

I believe this is intended as he shouldnt remain on the last frame and should you should set a pose after. I believe the correct syntax is more like

Play,_emotion: air guitar Set_pose: side

Example in one of the later ink scripts in the story.

PhoebeMitchell commented 1 month ago

Unless the requested functionally here is to play the animation while speaking?

ViMaSter commented 1 month ago

Actually you bring up a great point; I totally missed that SET_POSE and PLAY_EMOTION achieve different results when we were talking about this topic in the meeting.

Chatted with NightRoost about it again:

Right now…

What he'd like us to change to, is that…

While this could result in freeze frames, he prefers the added flexibility. If we have cases where a freeze frame feels weird, we can always replace a &SET_POSE:AirGuitar with the &PLAY_EMOTION:AirGuitar -> &SET_POSE:Normal, but having the option to remain in a pose would be great to have, unless you see a potential downside with having that extra option?