search

Studio-kalavati / Swaranotebook-bandish-editor

Bandish notation editor for Hindustani classical music
GNU Affero General Public License v3.0
20 stars 2 forks source link

Raga notes are not saved #84

Closed shark8me closed 1 year ago

shark8me commented 1 year ago

Change the default notes in a raga (e.g add komal svaras). Click on 'raga' again, the previous selected notes are not selected.

RajarshiRit commented 1 year ago

There are several other scopes to improvement I shall discuss after I return from the tour. The errors are as follows:

  1. After entering lyrics, when leaving the text keyboard leaves a whitespace, about half of the screen, persists.

  2. Noise while play, especially while editing for long time.

On Sun, 7 May 2023, 17:54 Kiran Karkera, @.***> wrote:

Change the default notes in a raga (e.g add komal svaras). Click on 'raga' again, the previous selected notes are not selected.

— Reply to this email directly, view it on GitHub https://github.com/Studio-kalavati/bandish-editor/issues/84, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUDDX6NTQSTHLG2XVMENRE3XE6IAJANCNFSM6AAAAAAXY2Y7LU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

shark8me commented 1 year ago

Thanks, Could you share a screenshot of the first issue?

On the second, do you know when it happens? All the time or when you do something specific?

On Mon, May 8, 2023, 8:43 PM Rajarshi Rit @.***> wrote:

There are several other scopes to improvement I shall discuss after I return from the tour. The errors are as follows:

  1. After entering lyrics, when leaving the text keyboard leaves a whitespace, about half of the screen, persists.

  2. Noise while play, especially while editing for long time.

On Sun, 7 May 2023, 17:54 Kiran Karkera, @.***> wrote:

Change the default notes in a raga (e.g add komal svaras). Click on 'raga' again, the previous selected notes are not selected.

— Reply to this email directly, view it on GitHub https://github.com/Studio-kalavati/bandish-editor/issues/84, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AUDDX6NTQSTHLG2XVMENRE3XE6IAJANCNFSM6AAAAAAXY2Y7LU

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Studio-kalavati/bandish-editor/issues/84#issuecomment-1538537016, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVX5CVRVM5ZJWGHD3UTJLXFEETLANCNFSM6AAAAAAXY2Y7LU . You are receiving this because you authored the thread.Message ID: @.***>

RajarshiRit commented 1 year ago

I will send it in one week or two. Currently busy with a tour.

On Tue, 9 May 2023, 21:53 Kiran Karkera, @.***> wrote:

Thanks, Could you share a screenshot of the first issue?

On the second, do you know when it happens? All the time or when you do something specific?

On Mon, May 8, 2023, 8:43 PM Rajarshi Rit @.***> wrote:

There are several other scopes to improvement I shall discuss after I return from the tour. The errors are as follows:

  1. After entering lyrics, when leaving the text keyboard leaves a whitespace, about half of the screen, persists.

  2. Noise while play, especially while editing for long time.

On Sun, 7 May 2023, 17:54 Kiran Karkera, @.***> wrote:

Change the default notes in a raga (e.g add komal svaras). Click on 'raga' again, the previous selected notes are not selected.

— Reply to this email directly, view it on GitHub https://github.com/Studio-kalavati/bandish-editor/issues/84, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AUDDX6NTQSTHLG2XVMENRE3XE6IAJANCNFSM6AAAAAAXY2Y7LU

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/Studio-kalavati/bandish-editor/issues/84#issuecomment-1538537016 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAAVX5CVRVM5ZJWGHD3UTJLXFEETLANCNFSM6AAAAAAXY2Y7LU

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Studio-kalavati/bandish-editor/issues/84#issuecomment-1540492165, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUDDX6NICZZSATKNHNK2XQ3XFJVQ5ANCNFSM6AAAAAAXY2Y7LU . You are receiving this because you commented.Message ID: @.***>

ameya-deshmukh commented 1 year ago

@shark8me love the project being having trained in Indian classical music myself! I've been exploring Clojure and wanted to start contributing, this seems like the perfect fit. Can I take this (or any other important issue) up?

shark8me commented 1 year ago

@ameya-deshmukh sounds good! Its worth taking a look, however this is a slightly complex issue. If you are familiar with Clojurescript + re-frame, it should be easier. I'll create a separate list (or set of labels) for issues that are appropriate for contributors new to the project

shark8me commented 1 year ago

This issue is a duplicate of #96 and is now fixed