Studio164a / Franklin

A responsive, retina ready WordPress crowdfunding theme.
3 stars 0 forks source link

Goal amount resets to Zero when campaign approved #2

Closed MetaHeavies closed 8 years ago

MetaHeavies commented 8 years ago

Hi - I understand this theme is no longer being supported, however it seems the latest WP update breaks some core functionality - namely that when a campaign is published by the admin, the campaign goal amount resets to zero, and the campaign is listed as successful.

Would be grateful for any ideas or direction before I start going through the code to try and figure this out!

Best

Gordon

ericnicolaas commented 8 years ago

Hi Gordon,

This was an issue in Appthemer Crowdfunding. You can get an updated version of the plugin that fixes this from https://github.com/Studio164a/appthemer-crowdfunding/archive/v1.9.6.zip

Cheers, Eric

MetaHeavies commented 8 years ago

Cheers Eric - I appreciate you getting back so fast.

Gordon

Faculty is a multi-disciplinary creative agency that tells stories through digital, experiential and film

www.fclty.com Follow us on twitter https://twitter.com/Faculty_

London ✈ Bangkok

On 1 February 2016 at 10:13, Eric Daams notifications@github.com wrote:

Hi Gordon,

This was an issue in Appthemer Crowdfunding. You can get an updated version of the plugin that fixes this from https://github.com/Studio164a/appthemer-crowdfunding/archive/v1.9.6.zip

Cheers, Eric

— Reply to this email directly or view it on GitHub https://github.com/Studio164a/Franklin/issues/2#issuecomment-177735087.

ericnicolaas commented 8 years ago

No worries. Got your email separately too, but I guess we've resolved everything here :)

MetaHeavies commented 8 years ago

Hey Eric

Just wanted to let you know I found a relatively minor but important bug in the updated plugin -

The _isfunded() function comparing the* current_amount* about against the _goalamount wasn't working correctly - the* goal_amount* was reading as a string (commas aren't getting stripped) not a number, so the method always returned true even if the _currentamount was less.

This was also true for the _percentcompleted() function.

My quick and dirty solution was to add a small function that would remove the comma from the goal amount. This could (and probably should) be set somewhere else but I didn't actually dig into the code that much.

$goal = $this->goal(false);

$b = str_replace(',', '', $goal);

if (is_numeric($b)) {

$goal = $b;

}

Best,

Gordon

Faculty is a multi-disciplinary creative agency that tells stories through digital, experiential and film

www.fclty.com Follow us on twitter https://twitter.com/Faculty_

London ✈ Bangkok

On 1 February 2016 at 12:18, Eric Daams notifications@github.com wrote:

No worries. Got your email separately too, but I guess we've resolved everything here :)

— Reply to this email directly or view it on GitHub https://github.com/Studio164a/Franklin/issues/2#issuecomment-177769202.