Open jchionh opened 1 year ago
@TheCherno Is there anything holding this PR back?
@coderabbitai review
The update introduces a new system for handling key events within the Walnut project. It establishes a method to set up key callbacks, allowing specific functions to be assigned to key events. This is achieved through the introduction of a key callback map, initialization and setting mechanisms for key callbacks, enhancing the project's interactivity and responsiveness to user input.
Files | Summary |
---|---|
Walnut/src/Walnut/Input/Input.cpp Walnut/src/Walnut/Input/Input.h |
Introduced s_KeyCallbackMap for storing key callbacks, added functionalities for setting and initializing key callbacks. |
🎉 A Celebration of Keys and Callbacks 🎉
In the realm of code, where the walnut trees grow,
A new update has come, with a bright, gleaming glow.
Keys now have a voice, callbacks their song,
Together in harmony, they dance along.
So here's to the changes, may they make our code leap,
As the rabbit watches over, never falling asleep.
🐰💻🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Existing Input class only checks for IsKeyDown, which checks the key state via glfwGetKey. This doesn't support keyboard's keypress delay and repeat events ASAP.
This PR adds support for custom key press callbacks, so that we can have a callback for every event emitted for a key press, and repeats follows the user's keyboard settings.
Reference for callbacks https://www.glfw.org/docs/3.3/input_guide.html#input_key
Summary by CodeRabbit