StudioSixPlusOne / rack-modules

VCV Rack modules
GNU General Public License v3.0
25 stars 8 forks source link

Iverson APC mini fader crashes Rack #100

Closed rogierg closed 1 year ago

rogierg commented 3 years ago

Hi there,

Many thanks for this awesome plugin. Instant techno FTW! 😊

I'm on Windows 10 using the 1.1.6 version of Rack. Often Rack will crash when one or multiple faders (default bind to probability) are moved rapidly. Based on my observations it does not matter what other plugins are used. I have seen this behavior on 2 different PC's.

What information do you need to debug this issue?

curlymorphic commented 3 years ago

Many thanks for your report. I have also had reports of this from the video overview was being made while using an APC mini. Having spent a few weeks trying to reproduce this bug I finally managed to narrow the issue down to a mixture of how VCV blocks midi messages with the audio block size, and the APC, and the windows midi drivers as this only appears to cause problems on windows 10. The short term fix we found to work is to change the audio block to 512 or 1024.

I am aware this is not an ideal fix, and am hoping the revised midi in VCV 2.0 will address the issue, the only alternative I can find is to not use the VCV midi implementation, but I shall refrain from this as it causes issues if other modules use midi.

If this does not solve your issue please let me know and I will endeavour to find a solution.

p.s as a small tip, if vcv does crash unplugging and replugging the USB lead may help, and should at least give you the opportunity to save you patch.

rogierg commented 3 years ago

Hey. Sorry for the late reply. 512 or 1024 does not resolve the issue sadly, though it does lessen it. Does this issue occur on an APC 40 as well?

curlymorphic commented 3 years ago

I am unsure if the apc crashes VCV, I sold mine a few years ago, but I feel it will not work with Iverson, due to the way each fader on the APC 40 being assigned individual midi channels. I am really hoping this issue is fixed with VCV in 2.0, as the apc mini will crash using the core midi plugins without Iverson being installed.

rogierg commented 3 years ago

Right... do you have some more information about the midi processing of VCV? Perhaps I can do some magic with filtering in MIDI-OX.

curlymorphic commented 3 years ago

From what I can work out, the apc mini sends many cc midi messages very quickly, even when only changed by a few places. It appears that on Windows this can freeze the midi driver, I have not replicated or had reports of this issue on other operating systems.

This behavior also occurs using the core midi plugins, you may have a good idea if you can prefilter the data before it is processed by VCV Rack, I would be keen to know if your idea progresses.

curlymorphic commented 1 year ago

Closing, as this issue appears to no longer be reproducible, assuming fixed upstream