StudioSixPlusOne / rack-modules

VCV Rack modules
GNU General Public License v3.0
26 stars 8 forks source link

V2 Update #115

Closed pgatt closed 1 year ago

pgatt commented 2 years ago

I think at least a basic version of your plugins cane be gotten by simple find and replace - MidiWidget has changed to MidiDisplay.

mattcollier commented 2 years ago

The latest word on this is here: https://github.com/StudioSixPlusOne/rack-modules/issues/112#issuecomment-951599878

pgatt commented 2 years ago

Hi, I was just wondering how you are going with the updates?

gitet commented 2 years ago

I would love to get Iverson back - used it with my akai midi controller - really miss that :-) Anyway - thank you for the effort!

d34dnik commented 2 years ago

Also waiting for a 2.0 release! i miss using my apcmini without hassle!!

blay commented 2 years ago

Would it be possible to get Iverson to run in v2 with some community effort?

I managed to build and get Iverson to work in VCV Rack 2 with my Akai Apc Mini. The module works as expected inside rack. The midi out works and lights up the buttons of the APC but midi in is unresponsive, maybe because the midi implementation in vcv changed and I only got it to build by updating some naming conventions (such as from MidiWidget to MidiDisplay).

Would be willing to collaborate with someone to get it working if possible.

Petervos2018 commented 2 years ago

@curlymorphic , Hi Dave....

https://github.com/StudioSixPlusOne/rack-modules/issues/112#issuecomment-951599878

Is this still a thing, or have you lost all interest in it ?

Greetings Peter.

curlymorphic commented 2 years ago

tbh, I have only used vcv a hand full of times since the release of V2. There are currently no plans for an update

Petervos2018 commented 2 years ago

tbh, I have only used vcv a hand full of times since the release of V2. There are currently no plans for an update

Thanks for responding so quickly.

👍

@pgatt do you want to step in ?

https://community.vcvrack.com/t/plugins-that-are-questionable-whether-there-will-be-v2-updates/14364/63?u=yeager

https://community.vcvrack.com/t/plugins-that-are-questionable-whether-there-will-be-v2-updates/14364/80?u=yeager

BioCore01 commented 1 year ago

too bad for us midi tools that the project is not carried over to Version 2.0 for integrated support for MIDI grid controllers. what are the elements that are missing, so that it can be resume?

curlymorphic commented 1 year ago

Thanks for taking an interest, I no longer use VCV or have the time to dedicate to updating these. Maybe someone else will.

BioCore01 commented 1 year ago

"" Iverson "" --> Looking for people and dev's that have interest about controlling a Sequencers with hardware midi in VcVrack2

https://community.vcvrack.com/t/reanimating-and-improving-iverson-jr-launchpad-sequencer/16950

curlymorphic commented 1 year ago

Thanks for the link, I was not aware of this proposed project, It looks really good, has a decent design, and more functionality than Iverson. I hope it progresses.

gitterdude commented 1 year ago

Here are the necessary changes for anyone who wants to compile this with Rack-2.2.x, to use the working modules, :

  1. remove src/modules/Iverson.cpp and src/modules/Zilah.cpp
  2. fix src/ctrl/SqHelper.h :

    --- a/src/ctrl/SqHelper.h
    +++ b/src/ctrl/SqHelper.h
    @@ -63,7 +63,7 @@ public:
     }
    
     static void setPanel(::rack::app::ModuleWidget* widget, const char* path) {
    -        widget->setPanel(rack::window::Window().loadSvg(::rack::asset::plugin(pluginInstance, path)));
    +        widget->setPanel(APP->window->loadSvg(::rack::asset::plugin(pluginInstance, path)));
     }
    
     static void openBrowser(const char* url) {
    @@ -73,10 +73,10 @@ public:
         return ::rack::asset::plugin(plugin, filename);
     }
     static float engineGetSampleRate() {
    -        return rack::engine::Engine().getSampleRate();
    +        return APP->engine->getSampleRate();
     }
     static float engineGetSampleTime() {
    -        return rack::engine::Engine().getSampleTime();
    +        return APP->engine->getSampleTime();
     }
    
     template <typename T>
gitet commented 1 year ago

@gitterdude patch works like a charm agains the v2upgrade branch (builds on my ubuntu 22.04 box with a bunch of warnings, but apart from that all seems to be working fine)

Did anyone try to asses how much effort would be needed to rework the remaining modules?

I'm just a humble pythonista with very rusty/rudimentary C++ skills and no prior exposure to the Rack SDK, so I'm not even going to guess...

gitet commented 1 year ago

@gitterdude - got curious: Made some changes to the Iverson module code - managed to compile it. Can add it in Rack 2.2.1 without crashing the module browser. Plugged in my Akai APC Mini and loaded the corresponding preset. The physical device seems to respond to (ALSA) midi out from the plugin (leds will light up), but not the other way round: Nothing seems to happen in the plugin when I push the buttons on the midi device - managed to work around that by using the MIDI-CAT module from stoermelder - so there seems to be something wrong with the midi-in functionality in Iverson.

Do you know if there is any coordinated effort being undertaken with the goal of getting this module collection ported to V2 ?

gitterdude commented 1 year ago

No idea, I'm afraid; I'm just an ordinary user who thought I'd share the minor hoops I had to go through to getting most of the modules to work.

Maybe you should ask on https://community.vcvrack.com/c/development/8

gitet commented 1 year ago

Ok. At least we have some of the modules working - good work you did with that! Will ask around and see if I can find out.

curlymorphic commented 1 year ago

Ok, after a long time, I have taken a look at this module, and at first, glance has it working under V2.0, but I only have a Linux box, so I can't test windows and mac builds. It would be cool if you could let me know how this update works.

I have an alpha release of the studio six plus one module, working on Rack 2..0

https://github.com/StudioSixPlusOne/rack-modules/releases/tag/v2.0.1b

pgatt commented 1 year ago

Getting these errors when attempting to build on Mac

In file included from src/modules/Hula.cpp:1:
In file included from ./src/plugin.hpp:2:
In file included from ../../include/rack.hpp:22:
In file included from ../../include/common.hpp:15:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/string:522:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/algorithm:653:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/functional:500:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__functional/function.h:19:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__memory/compressed_pair.h:171:12: error: static_cast from 'std::__compressed_pair<std::allocator<HulaComp<WidgetComposite>>, HulaComp<WidgetComposite>> *' to 'std::__compressed_pair<std::allocator<HulaComp<WidgetComposite>>, HulaComp<WidgetComposite>>::_Base1 *' (aka '__compressed_pair_elem<std::allocator<HulaComp<WidgetComposite>>, 0> *'), which are not related by inheritance, is not allowed
    return static_cast<_Base1*>(__pair);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__memory/shared_ptr.h:348:74: note: in instantiation of member function 'std::__compressed_pair<std::allocator<HulaComp<WidgetComposite>>, HulaComp<WidgetComposite>>::__get_first_base' requested here
            typename _CompressedPair::_Base1* __first = _CompressedPair::__get_first_base(__as_pair);
                                                                         ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__memory/shared_ptr.h:341:27: note: in instantiation of member function 'std::__shared_ptr_emplace<HulaComp<WidgetComposite>, std::allocator<HulaComp<WidgetComposite>>>::_Storage::__get_alloc' requested here
            ::new ((void*)__get_alloc()) _Alloc(_VSTD::move(__a));
                          ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__memory/shared_ptr.h:291:11: note: in instantiation of member function 'std::__shared_ptr_emplace<HulaComp<WidgetComposite>, std::allocator<HulaComp<WidgetComposite>>>::_Storage::_Storage' requested here
        : __storage_(_VSTD::move(__a))
          ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__memory/shared_ptr.h:1106:55: note: in instantiation of function template specialization 'std::__shared_ptr_emplace<HulaComp<WidgetComposite>, std::allocator<HulaComp<WidgetComposite>>>::__shared_ptr_emplace<Hula *>' requested here
    ::new ((void*)_VSTD::addressof(*__guard.__get())) _ControlBlock(__a, _VSTD::forward<_Args>(__args)...);
                                                      ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__memory/shared_ptr.h:1115:19: note: in instantiation of function template specialization 'std::allocate_shared<HulaComp<WidgetComposite>, std::allocator<HulaComp<WidgetComposite>>, Hula *, void>' requested here
    return _VSTD::allocate_shared<_Tp>(allocator<_Tp>(), _VSTD::forward<_Args>(__args)...);
                  ^
src/modules/Hula.cpp:20:21: note: in instantiation of function template specialization 'std::make_shared<HulaComp<WidgetComposite>, Hula *, void>' requested here
        hula = std::make_shared<Comp> (this);
                    ^
In file included from src/modules/Hula.cpp:1:
In file included from ./src/plugin.hpp:2:
In file included from ../../include/rack.hpp:22:
In file included from ../../include/common.hpp:15:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/string:522:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/algorithm:653:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/functional:500:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__functional/function.h:19:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__memory/compressed_pair.h:175:12: error: static_cast from 'std::__compressed_pair<std::allocator<HulaComp<WidgetComposite>>, HulaComp<WidgetComposite>> *' to 'std::__compressed_pair<std::allocator<HulaComp<WidgetComposite>>, HulaComp<WidgetComposite>>::_Base2 *' (aka '__compressed_pair_elem<HulaComp<WidgetComposite>, 1> *'), which are not related by inheritance, is not allowed
    return static_cast<_Base2*>(__pair);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__memory/shared_ptr.h:354:75: note: in instantiation of member function 'std::__compressed_pair<std::allocator<HulaComp<WidgetComposite>>, HulaComp<WidgetComposite>>::__get_second_base' requested here
            typename _CompressedPair::_Base2* __second = _CompressedPair::__get_second_base(__as_pair);
                                                                          ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__memory/shared_ptr.h:306:53: note: in instantiation of member function 'std::__shared_ptr_emplace<HulaComp<WidgetComposite>, std::allocator<HulaComp<WidgetComposite>>>::_Storage::__get_elem' requested here
    _Tp* __get_elem() _NOEXCEPT { return __storage_.__get_elem(); }
                                                    ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__memory/shared_ptr.h:1108:76: note: in instantiation of member function 'std::__shared_ptr_emplace<HulaComp<WidgetComposite>, std::allocator<HulaComp<WidgetComposite>>>::__get_elem' requested here
    return shared_ptr<_Tp>::__create_with_control_block((*__control_block).__get_elem(), _VSTD::addressof(*__control_block));
                                                                           ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__memory/shared_ptr.h:1115:19: note: in instantiation of function template specialization 'std::allocate_shared<HulaComp<WidgetComposite>, std::allocator<HulaComp<WidgetComposite>>, Hula *, void>' requested here
    return _VSTD::allocate_shared<_Tp>(allocator<_Tp>(), _VSTD::forward<_Args>(__args)...);
                  ^
src/modules/Hula.cpp:20:21: note: in instantiation of function template specialization 'std::make_shared<HulaComp<WidgetComposite>, Hula *, void>' requested here
        hula = std::make_shared<Comp> (this);
pgatt commented 1 year ago

Think it may be the same issue as #112

curlymorphic commented 1 year ago

@pgatt Thanks for looking, I shall go back and look at #112, iirc you posted a link to some working code. you have also mentioned some alterations to svg loading, so these are my next areas to look at.

I have just made a new beta release, works on linux, hopefully, windows, I would expect not on mac yet

https://github.com/StudioSixPlusOne/rack-modules/releases/tag/v2.0.1c

SteveRussell33 commented 1 year ago

Windows 10 (GCC v12.2) build failure [v2tidy branch] (removed FLAGS += -fmax-errors=5 from Makefile)

In file included from src/modules/Hula.cpp:2:
./src/composites/Hula.h:116:40: error: field 'lastOuts' has incomplete type 'std::array<rack::simd::Vector<float, 4>, 4>'
  116 |     std::array<float_4, SIMD_CHANNELS> lastOuts;
      |                                        ^~~~~~~~
In file included from C:/msys64/mingw64/include/c++/12.2.0/bits/stl_map.h:63,
                 from C:/msys64/mingw64/include/c++/12.2.0/map:61,
                 from ../../include/network.hpp:2,
                 from ../../include/rack.hpp:28,
                 from ./src/plugin.hpp:2,
                 from src/modules/Hula.cpp:1:
C:/msys64/mingw64/include/c++/12.2.0/tuple:1595:45: note: declaration of 'struct std::array<rack::simd::Vector<float, 4>, 4>'
 1595 |   template<typename _Tp, size_t _Nm> struct array;
      |                                             ^~~~~
./src/composites/Hula.h:117:40: error: field 'phases' has incomplete type 'std::array<rack::simd::Vector<float, 4>, 4>'
  117 |     std::array<float_4, SIMD_CHANNELS> phases;
      |                                        ^~~~~~
C:/msys64/mingw64/include/c++/12.2.0/tuple:1595:45: note: declaration of 'struct std::array<rack::simd::Vector<float, 4>, 4>'
 1595 |   template<typename _Tp, size_t _Nm> struct array;
      |                                             ^~~~~
./src/composites/Hula.h:118:40: error: field 'fineTuneVocts' has incomplete type 'std::array<rack::simd::Vector<float, 4>, 4>'
  118 |     std::array<float_4, SIMD_CHANNELS> fineTuneVocts;
      |                                        ^~~~~~~~~~~~~
C:/msys64/mingw64/include/c++/12.2.0/tuple:1595:45: note: declaration of 'struct std::array<rack::simd::Vector<float, 4>, 4>'
 1595 |   template<typename _Tp, size_t _Nm> struct array;
      |                                             ^~~~~
./src/composites/Hula.h:123:93: error: field 'decimators' has incomplete type 'std::array<sspo::Decimator<4, 1, rack::simd::Vector<float, 4> >, 4>'
  123 |     std::array<sspo::Decimator<oversampleCount, oversampleQuality, float_4>, SIMD_CHANNELS> decimators;
      |                                                                                             ^~~~~~~~~~
C:/msys64/mingw64/include/c++/12.2.0/tuple:1595:45: note: declaration of 'struct std::array<sspo::Decimator<4, 1, rack::simd::Vector<float, 4> >, 4>'
 1595 |   template<typename _Tp, size_t _Nm> struct array;
      |                                             ^~~~~
./src/composites/Hula.h:124:69: error: field 'oversampleBuffers' has incomplete type 'std::array<std::array<rack::simd::Vector<float, 4>, 4>, 4>'
  124 |     std::array<std::array<float_4, oversampleCount>, SIMD_CHANNELS> oversampleBuffers;
      |                                                                     ^~~~~~~~~~~~~~~~~
C:/msys64/mingw64/include/c++/12.2.0/tuple:1595:45: note: declaration of 'struct std::array<std::array<rack::simd::Vector<float, 4>, 4>, 4>'
 1595 |   template<typename _Tp, size_t _Nm> struct array;
      |                                             ^~~~~
./src/composites/Hula.h:125:54: error: field 'dcOutFilters' has incomplete type 'std::array<sspo::BiQuad<rack::simd::Vector<float, 4> >, 4>'
  125 |     std::array<sspo::BiQuad<float_4>, SIMD_CHANNELS> dcOutFilters;
      |                                                      ^~~~~~~~~~~~
C:/msys64/mingw64/include/c++/12.2.0/tuple:1595:45: note: declaration of 'struct std::array<sspo::BiQuad<rack::simd::Vector<float, 4> >, 4>'
 1595 |   template<typename _Tp, size_t _Nm> struct array;
      |                                             ^~~~~
./src/composites/Hula.h:126:54: error: field 'lpFilters' has incomplete type 'std::array<sspo::BiQuad<rack::simd::Vector<float, 4> >, 4>'
  126 |     std::array<sspo::BiQuad<float_4>, SIMD_CHANNELS> lpFilters;
      |                                                      ^~~~~~~~~
C:/msys64/mingw64/include/c++/12.2.0/tuple:1595:45: note: declaration of 'struct std::array<sspo::BiQuad<rack::simd::Vector<float, 4> >, 4>'
 1595 |   template<typename _Tp, size_t _Nm> struct array;
      |                                             ^~~~~
./src/composites/Hula.h:128:54: error: field 'depthFilters' has incomplete type 'std::array<sspo::BiQuad<rack::simd::Vector<float, 4> >, 4>'
  128 |     std::array<sspo::BiQuad<float_4>, SIMD_CHANNELS> depthFilters;
      |                                                      ^~~~~~~~~~~~
C:/msys64/mingw64/include/c++/12.2.0/tuple:1595:45: note: declaration of 'struct std::array<sspo::BiQuad<rack::simd::Vector<float, 4> >, 4>'
 1595 |   template<typename _Tp, size_t _Nm> struct array;
      |                                             ^~~~~
./src/composites/Hula.h:129:54: error: field 'feedbackFilters' has incomplete type 'std::array<sspo::BiQuad<rack::simd::Vector<float, 4> >, 4>'
  129 |     std::array<sspo::BiQuad<float_4>, SIMD_CHANNELS> feedbackFilters;
      |                                                      ^~~~~~~~~~~~~~~
C:/msys64/mingw64/include/c++/12.2.0/tuple:1595:45: note: declaration of 'struct std::array<sspo::BiQuad<rack::simd::Vector<float, 4> >, 4>'
 1595 |   template<typename _Tp, size_t _Nm> struct array;
      |                                             ^~~~~
./src/composites/Hula.h: In instantiation of 'void HulaComp<TBase>::init() [with TBase = WidgetComposite]':
src/modules/Hula.cpp:24:19:   required from here
./src/composites/Hula.h:160:20: error: using invalid field 'HulaComp<TBase>::fineTuneVocts'
  160 |     for (auto& f : fineTuneVocts)
      |                    ^~~~~~~~~~~~~
./src/composites/Hula.h:166:20: error: using invalid field 'HulaComp<TBase>::lastOuts'
  166 |     for (auto& l : lastOuts)
      |                    ^~~~~~~~
./src/composites/Hula.h:169:20: error: using invalid field 'HulaComp<TBase>::phases'
  169 |     for (auto& p : phases)
      |                    ^~~~~~
./src/composites/Hula.h: In instantiation of 'void HulaComp<TBase>::setSampleRate(float) [with TBase = WidgetComposite]':
src/modules/Hula.cpp:35:29:   required from here
./src/composites/Hula.h:142:20: error: using invalid field 'HulaComp<TBase>::lpFilters'
  142 |     for (auto& l : lpFilters)
      |                    ^~~~~~~~~
./src/composites/Hula.h:145:21: error: using invalid field 'HulaComp<TBase>::dcOutFilters'
  145 |     for (auto& dc : dcOutFilters)
      |                     ^~~~~~~~~~~~
./src/composites/Hula.h:149:20: error: using invalid field 'HulaComp<TBase>::depthFilters'
  149 |     for (auto& d : depthFilters)
      |                    ^~~~~~~~~~~~
./src/composites/Hula.h:152:20: error: using invalid field 'HulaComp<TBase>::feedbackFilters'
  152 |     for (auto& f : feedbackFilters)
      |                    ^~~~~~~~~~~~~~~
make: *** [../../compile.mk:87: build/src/modules/Hula.cpp.o] Error 1
make: *** Waiting for unfinished jobs....
curlymorphic commented 1 year ago

@SteveRussell33 Thanks for the testing, I have just made a new release, where I disable the module in question "hula" now I can build on a virtual windows pc, but have no idea if it runs.

This may have also improved the mac compiling.

https://github.com/StudioSixPlusOne/rack-modules/releases/tag/v2.0.1d

pgatt commented 1 year ago

It builds and runs here in Mac Dave.Sent from my iPhoneOn 1 Jan 2023, at 12:02 am, Dave French @.***> wrote: @SteveRussell33 Thanks for the testing, I have just made a new release, where I disable the module in question "hula" now I can build on a virtual windows pc, but have no idea if it runs. This may have also improved the mac compiling. https://github.com/StudioSixPlusOne/rack-modules/releases/tag/v2.0.1d

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

curlymorphic commented 1 year ago

It builds and runs here in Mac

That's the news I wanted, and that is really encouraging, now I have a few things to do, but I can see this being ready to submit to the VCV library in the coming days.

I shall leave the two new modules until a later release, as they obviously need more testing.

I think that leaves updating the loading of fonts and images and naming ports. When I have this done, I will post links for testing on the forums.

SteveRussell33 commented 1 year ago

I can compile from the latest v2tidy branch commit on Windows.

I did add the Amburgh module back in reverting https://github.com/StudioSixPlusOne/rack-modules/commit/eee10e9fa9ad4297e62e54c3ada2ffaa3ddd3ab4 this compiles OK. All modules appear in the browser and can be added to an empty rack without issue.

However, clicking the Parameter Select widget on the Zazel module seg faults:

Thread 1 received signal SIGSEGV, Segmentation fault.
0x00007ffb939bad86 in Zazel::updateParamHandle (this=0x2556ea484d0) at src/modules/Zazel.cpp:135
135             ParamQuantity* pq = paramHandle.module->paramQuantities[paramHandle.paramId];
(gdb) bt
#0  0x00007ffb939bad86 in Zazel::updateParamHandle (this=0x2556ea484d0) at src/modules/Zazel.cpp:135
#1  ParameterSelectWidget::onDeselect (e=..., this=0x25578012400) at src/modules/Zazel.cpp:364
#2  ParameterSelectWidget::onDeselect (this=0x25578012400, e=...) at src/modules/Zazel.cpp:351
#3  0x00007ffba8ee4803 in rack::widget::EventState::setSelectedWidget (w=<optimized out>, this=0x2556de054e0) at src/widget/event.cpp:93
#4  rack::widget::EventState::handleButton (this=0x2556de054e0, pos=..., button=0, action=1, mods=32) at src/widget/event.cpp:158
#5  0x00007ffba8ee6dbe in rack::window::mouseButtonCallback (win=<optimized out>, button=0, action=1, mods=32) at src/window/Window.cpp:151
#6  0x00007ffba8f2de65 in windowProc (hWnd=0x3404b8, uMsg=513, wParam=<optimized out>, lParam=<optimized out>)
    at C:/_Projects/VCVRack/V2/Rack_SR/dep/glfw/src/win32_window.c:813
#7  0x00007ffbdf47e7e8 in USER32!CallWindowProcW () from /c/WINDOWS/System32/USER32.dll
#8  0x00007ffbdf47e47e in USER32!CallWindowProcW () from /c/WINDOWS/System32/USER32.dll
#9  0x00007ffbd045f0f0 in glPushClientAttrib () from /c/WINDOWS/SYSTEM32/OPENGL32.dll
#10 0x00007ffbdf47e7e8 in USER32!CallWindowProcW () from /c/WINDOWS/System32/USER32.dll
#11 0x00007ffbdf47e229 in USER32!DispatchMessageW () from /c/WINDOWS/System32/USER32.dll
#12 0x00007ffba8f310f3 in _glfwPollEventsWin32 () at C:/_Projects/VCVRack/V2/Rack_SR/dep/glfw/src/win32_window.c:1981
#13 0x00007ffba8ee7379 in rack::window::Window::step (this=this@entry=0x2556e12a0c0) at src/window/Window.cpp:430
#14 0x00007ffba8ee7cf8 in rack::window::Window::run (this=0x2556e12a0c0) at src/window/Window.cpp:408
#15 0x00007ff7170f0e73 in main (argc=<optimized out>, argv=<optimized out>) at adapters/standalone.cpp:259
curlymorphic commented 1 year ago

@SteveRussell33

Thanks for testing and the bug report, good to know windows builds are now running.

I have pushed a commit to v2Tidy branch, where Zazel should now work, I have also labeled the ports, and hopefully fixed the loading of fonts, but I have still to test when vcv is running as a plugin.

I am thinking of installing windows on one of my pc's again, I am enjoying getting back into vcv, and it is a lot easier on the wallet than building DIY modular.

Petervos2018 commented 1 year ago

I am enjoying getting back into vcv,

👍

pgatt commented 1 year ago

The errors regarding Hula.cpp are fixed if you #include <array>

SteveRussell33 commented 1 year ago

The errors regarding Hula.cpp are fixed if you #include <array>

Confirmed, when added to src/composites/Hula.h

curlymorphic commented 1 year ago

Thanks for this, looks like it will be a full release of all modules, including the new modules Hula, and Amburgh.

Just a quick progress report, I have reinstalled windows on my desktop, along with Ableton for testing, and have a couple of issues to deal with, but having spent some time reading the last couple of years worth of forum posts I have a good idea of what I have to change. I have also been spending time setting up a VM, so I don't have to keep rebooting to switch operating systems, The time spent doing this I am sure will prove to be a good investment in the long run. I have not used VCV since the release of 2.0 and have some learning to do r.e. VST integration, and how best to utilise this, but that all part of the fun.

I have also been working on getting my unit and performance tests compiled again, as I really want these as part of my GitHub CI toolchain. I made headway with this last night, but have more to do. In the longer term, I would like to move away from using the code I borrowed from squinky labs to use a real testing and mocking suite, but that will not be for this release. I am surprised that anyone could figure out the current implementation and the "module code" is actually in the composites, coming back to this code after a couple of years has made me realise how messy my current system is.

I am hoping with a few more sessions working on this plugin I can get a release ready to put on the forums for testing. The more I am doing, the more enthusiastic I am getting, and am really thinking about developing more modules, and getting back into the community. I have been designing and building a DIY analogue modular synth, and have learned a lot from the experience that I could well extrapolate to the digital domain. Software is also cheaper to work on, I could buy a Mac and a couple of daws for testing for less than it would cost me in 6 months of building physical modules, but I'm not going to rush into this investment just yet.

Thanks for the support, and for reading my waffle, I'm not sure I would be so enthusiastic with out it :)

jpnielsen commented 1 year ago

I've been playing with two Novation Launchpad mkII's and your Iverson. Very nice. Thank you.

image
curlymorphic commented 1 year ago

@jpnielsen

Thank you for testing, I am pleased you like it. The only controller I have two of for testing is the APC mini, and I think most only use a single controller.

Are you using 8face to switch sequences?

gitet commented 1 year ago

@curlymorphic tested the linux version - my APC Mini is now working again under Linux with the Iverson modules. So nice to be able to use the controller again :-) Thank you for this!

curlymorphic commented 1 year ago

@gitet

Thank you for taking the time to test and report.

jpnielsen commented 1 year ago

Are you using 8face to switch sequences?

yes, sequences and main/alt probabilities. midi-mapped to other buttons on the launchpad - or sequenced.

The library page is here

rogierg commented 1 year ago

@curlymorphic my APC is working again on v2 on Windows \o/. Many thanks to you and everyone to get it going. To help others I've shared my compiled binary here: https://github.com/rogierg/6plus1-rack-modules/releases/tag/v2.0.1d

Download the StudioSixPlusOne.zip and extract it to C:\Users[your_username]\Documents\Rack2\plugins

curlymorphic commented 1 year ago

@rogierg nice to know you are enjoying it.

I have posted a link on the vcv forum with binaries for Windows, Linux, intel mac, and arm mac. https://community.vcvrack.com/t/studio-6-1-updated-plugin-for-v2-0-at-last/19096

I am currently writing additional unit tests before I release to the library. I have found a couple of edge case bugs with the new filter and VCO that I have fixed, but I am still checking.

I still have to update the readme, and shall be renaming the repository, so the folder name will be StudioSixPlusOne, not the current no descriptive rack-modules

curlymorphic commented 1 year ago

Closed as Migration to V2.0 complete