search

StudioSixPlusOne / rack-modules

VCV Rack modules
GNU General Public License v3.0
26 stars 8 forks source link

Eva #67

Closed curlymorphic closed 4 years ago

curlymorphic commented 4 years ago

Eva

Eva

Slimline polyphonic mixer with variable curve attenuator.

curlymorphic commented 4 years ago

mattcollier comented in a test patch " If gain shape is 0, attenuverter seems to operate normally. But with any other gain shape AND CV on the attenuverter looks like gain goes off the chart.

Also for this commit f0fd4798d1ac34bb626b7f3b2d5f9499878422ee the faceplate graphics are wonky and don't line up, 6+1 logo is too large. Labels on attenuverter are covered by knob. "

Found a difference in simd::pow, compared with std::pow when attenuverter curves were held at zero, this manifested it's self as a very large gain when used with a squarewave automating the gain, only when the gain was held at zero. This has now been fixed and added to the unit test.

The Logo has been made smaller, The curve symbols on the UI have now been edge aligned with the text below, a change from the center align previously used.

mattcollier commented 4 years ago

Some comments in the patch.

Based on the current implementation, I'm questioning the need for the attack slew knob. I'm thinking using an AD envelope generator is just a better solution. If the knob stays in, then the UI needs some improvement.

Maybe one or two additional inputs would be more valuable than the gain shape.

Also, is the aspect ratio on the 6+1 logo being maintained?

gain_shape.vcv.zip

curlymorphic commented 4 years ago

Based on the current implementation, I'm questioning the need for the attack slew knob. I'm thinking using an AD envelope generator is just a better solution. If the knob stays in, then the UI needs some improvement.

I shall be very happy to remove this requested feature and returning to the original design with 8 inputs and an attenuverter knob as per pr #27, this module was suffering feature creep, something as a team we should focus on improving.

You mention adding an envelope generator, this should be a separate module, but would be required to provide an advantage over the various implementations already offered in the VCV library. I am interested to hear your ideas.

curlymorphic commented 4 years ago

Eva The attenuation curve has been removed and reverted back to the original 8 inputs as is common on this style of a mixer.