search

StudioSixPlusOne / rack-modules

VCV Rack modules
GNU General Public License v3.0
27 stars 8 forks source link

Tyrant add polyphonic trigger and shuffle probability #71

Closed curlymorphic closed 4 years ago

curlymorphic commented 4 years ago

Quoted from Omri Cohen

"About Tyrant, I really enjoyed the fact that it's possible to control the probability per channel with something like Polycon, but I wish it was also possible for the Trigger and Shuffle probability so it was easier to get interesting rhythms and variation. But other than that, they work really nicely and are very inspiring."

This PR implements the requested features, once we are happy I ask be asking Omri if I have understood his requirements before we release.

curlymorphic commented 4 years ago

The addition of the polyphonic shuffle and trigger probability was a large refactor, internally to now runs as 16 shift registers, with a single output stage from each register used.

This had introduced bugs with the reset and accent controls. The latest pull request greatly extends the tests on Tyrant and fixes the bugs found.

@mattcollier I feel priority should be given to ensuring when the trigger probability CV input and the shuffle probability CV input are unconnected or have monophonic signals that the behavior matches that of the initial release. Then we can pass to Omri to check that the new behavior is as intended.

curlymorphic commented 4 years ago

I have sent a build to Omri for testing, and I now have the response that the new features act as he intended.