search

Studiosity / grover

A Ruby gem to transform HTML into PDFs, PNGs or JPEGs using Google Puppeteer/Chromium
MIT License
892 stars 99 forks source link

"insecure download" warning when downloading from pdf generator #236

Open yehudaclinton opened 3 months ago

yehudaclinton commented 3 months ago

I'm getting "insecure download" warning when downloading with chrome lately. I have proper TLS and it doesn't happen with prawn.

  grover = Grover.new(html, format: Params.paper_size)

  pdf = grover.to_pdf

  return send_data pdf, filename: 'download.pdf', type: 'application/pdf'
abrom commented 3 months ago

What have you tried to do to debug this? I can't replicate it and you haven't provided much to go on.

Is it all content or just some? Have you tried setting the content to something specific? html = 'works?' ?? Is it all PDFs? Have you tried returning a static PDF? What versions of things (grover/puppeteer/node) are you running?

yehudaclinton commented 3 months ago

What have you tried to do to debug this? I can't replicate it and you haven't provided much to go on.

Is it all content or just some? Have you tried setting the content to something specific? html = 'works?' ?? Is it all PDFs? Have you tried returning a static PDF? What versions of things (grover/puppeteer/node) are you running?

Grover version 1.1.5 Its true that it is difficult for me to be certain that Grover is the issue but why else are some of the downloads giving that issue and not others. Either way its a new annoying feature from chrome that is bothering out clients for no good reason.