search

Studiosity / grover

A Ruby gem to transform HTML into PDFs, PNGs or JPEGs using Google Puppeteer/Chromium
MIT License
946 stars 107 forks source link

fix: introduce ignoreDefaultArgs into launchParams #246

Open tomaswitek opened 4 months ago

tomaswitek commented 4 months ago

I encountered an issue when using German hyphens on Linux.

Snímek obrazovky 2024-07-11 v 13 34 02

The following images were generated with identical code on different environments. The left side is Linux, and the right side is MacOS. Here is a bug report on the Chromium website: https://issues.chromium.org/issues/40933841 There is a workaround for Puppeteer:

puppeteer.launch({
  ignoreDefaultArgs: ['--disable-component-update'],
})

Unfortunately,ignoreDefaultArgs are not passed via Grover. This PR fixes it.