Study-Together-Org / time_counter

12 stars 5 forks source link

Decrease of all time hours + lost streaks #26

Closed Totti56 closed 3 years ago

Totti56 commented 3 years ago

I noticed that my streaks got dropped in the time difference of (20:18 - 21:04, see images below, last image has lost streaks) even though I had above 1 hours daily. image Besides that I noticed that my hours started to decrease, while I was still studying in a call, so it wouldn't make sense for it to decrease the daily as well as the all time stats. image

Zackhardtoname commented 3 years ago

I can't believe this is happening :( Guess a thorough debugging is required. Right now I am too busy

Zackhardtoname commented 3 years ago

reset = await utilities.get_redis_score(self.redis_client, yesterday_str, user_id) >= threshold Should be <...

Zackhardtoname commented 3 years ago

Now both issues hopefully should be resolved. I'll revisit this to see if it's closable in perhaps 8 days.

avramkji commented 3 years ago

image Don't know if this is related. Please check this person's day hours.

Zackhardtoname commented 3 years ago

image Don't know if this is related. Please check this person's day hours.

Can u be more specific about what the problems are? Daily over 24 hours?

avramkji commented 3 years ago

He has daily hours more than 24h which isn't possible since there are only 24h in a day.

Zackhardtoname commented 3 years ago

image

Why does 1.0 say he only has 3.6 h when he studied for over 12 hours for sure in the last 24 hours? @Gugu7264 @avramkjiprovski

Zackhardtoname commented 3 years ago

He has daily hours more than 24h which isn't possible since there are only 24h in a day.

Yes you are right! I combined the previous logic into a fix that hopefully will resolve it. Gotta see if too many hours or any decrease happens again

Zackhardtoname commented 3 years ago

Just needa watch out for #28