Study-Together-Org / time_counter

12 stars 5 forks source link

Missing Discord API events making Hours on v2 increase in significant numbers #37

Closed gene4587 closed 3 years ago

gene4587 commented 3 years ago

Issue reported by: DarkLord#3850 (727922301869228062)

my hours and rank in Study Counter Beta just shot up by many hours in a couple of minutes and it's showing me as #1 on the lb eventhough i shouldn't be #1

This is the lb on v2 (time based on UTC+8) image

This the lb today, 17 Feb (time based on UTC+8) image

Zackhardtoname commented 3 years ago

yeah clearly discord api issue like the one we handled before. (We can prob find evidence by just looking into dyno logs).

Currently, unfortunately, there's nothing we can do about it... Could you kindly use the change command to fix the people who jumped to the top by comparing v2 and v1? Thanks!

==

Zackhardtoname commented 3 years ago

records proving discord API issue

image chat history confirming it's a discord API issue

Zackhardtoname commented 3 years ago

image Nobody has a solution

gene4587 commented 3 years ago

A lot of the people in the first page of the ~lb had name changes so I can't match it to their v1 hours in the lb

gene4587 commented 3 years ago

Is it possible to do it by bulk? Seems like there's a lot of people who has stats that are boosted up.

Arianthell commented 3 years ago

Could you kindly use the change command to fix the people who jumped to the top by comparing v2 and v1? Thanks!

==

Just my 2 cents: v1 hasn't been updating for the past few days, creating extreme gaps between v1 and v2. This is what I meant when I said we shouldn't change people's hours, because v1 is more fragile and prone to mistakes. v1 stops displaying hours during API issues, or doesn't count at all during outage. People will notice and complain when we erase big amount of hours from their data. This is why we should not change people's hours ourselves.

If you want us change people's hours manually we need access to their actual data (which is shown on graphs I assume), and permission/instructions from Nadir.

Zackhardtoname commented 3 years ago

Doing it in bulk is possible but will require a bit of coding work. I don't know what the graph thing really is and how it is easier as @nadir7379 never explained to me Since I am still trying to mitigate this issue, if manual changes are too much, you could just hold off and kindly report any cases like this here. If we are lucky, maybe this will be fixed by our recent changes.

Arianthell commented 3 years ago

Doing it in bulk is possible but will require a bit of coding work. I don't know what the graph thing really is and @nadir7379 never explained to me Since I am still trying to mitigate this issue, if manual changes are too much, you could just hold off and kindly report any cases like this here. If we are lucky, maybe this will be fixed by our recent changes.

Nadir has some fancy graphs showing data of users, but I don't know how it works and how dependent it is to API (as in I do not know if it's showing correct data at all times even when Study!Counter is frozen or showing inaccurate data.

But either way, it is not about it being too much of work. It's just, whether we do it manually or in bulk, v1 is not accurate to begin with, so changing users' hours by referencing v1 is simply wrong. If and when they come and say "I just lost X amount of hours" and claim that it's incorrect, we have no ground of proving and defending why we changed their hours. Simply because we (as staff members) have no way to confirm their actual hours.

Zackhardtoname commented 3 years ago

For future reports of this issue, please kindly provide if convenient

  1. your timezone (the one discord itself uses; so it might be different from the one you gave to the timezone bot)
  2. screenshots and message links to the dyno logs (ideally when the irregularities happen)
  3. screenshots and message links to the commands the user has issued
Zackhardtoname commented 3 years ago

Seems to be resolved via some clever code