Study-Together-Org / time_counter

12 stars 5 forks source link

Add script for batch updating study roles #55

Closed Ruborcalor closed 3 years ago

Ruborcalor commented 3 years ago

Real time role updates are taken care of in #13. This pull request adds:

Zackhardtoname commented 3 years ago

Thanks for working on this! It looks like it's unfinished? In particular, sqlalchemytest.py has incomplete statements.

Zackhardtoname commented 3 years ago

I incorporated the ideas into the recent role updates for #13 I would love to merge this one in though for the other ideas like pipefile and tests. When you are done, could you kindly add a description of the changes? Thanks!

Ruborcalor commented 3 years ago

Nice stuff with #13, definitely the better approach!

avramkji commented 3 years ago

I believe that both of these issues are fixed now. I'm documenting this here for the sake of documenting events and because it seems to me that it was related to this issue thread.

Some members saying that their roles haven't updated as well counter bot taking too long to return !me output in command spam channels.

Ruborcalor commented 3 years ago

I incorporated the ideas into the recent role updates for #13 I would love to merge this one in though for the other ideas like pipefile and tests. When you are done, could you kindly add a description of the changes? Thanks!

I updated the description of the changes:

Real time role updates are taken care of in #13. This pull request adds:

Zackhardtoname commented 3 years ago

I believe that both of these issues are fixed now. I'm documenting this here for the sake of documenting events and because it seems to me that it was related to this issue thread.

Some members saying that their roles haven't updated as well counter bot taking too long to return !me output in command spam channels.

Yeah at first I was issuing API calls even if the role I calculated to add was already assigned before and hit rate-limiting from discord. be658d6 should have fixed that problem.