search

Study-Together-Org / time_counter

12 stars 5 forks source link

Update to discord.py 1.7.2 #60

Closed Totti56 closed 3 years ago

Totti56 commented 3 years ago

Strangely enough it removed a few hashes but all the version should be the same, not sure why it did that tho. So, I am not quite sure if I did it correctly, but it should be. Also, this is my first time doing a pull request. I hope I am doing everything correctly t-t

Zackhardtoname commented 3 years ago

Sorry it does not look right to me because I feel that Pipfile should also have different discord.py version? Also I see in the doc that "Do not keep Pipfile.lock in version control if multiple versions of Python are being targeted", which applies to us. (I and likely Cole use 3.9 in Arch, while the Ubuntu server only has 3.6). So Pipfile.lock should not be version controlled at all?

I am completely new to Pipenv but love it! It'd be great if we use this instead of requirements.txt. @Ruborcalor could you kindly take over the required changes and this GH issue?

Ruborcalor commented 3 years ago

Yes the Pipfile should also have a different discord.py version. I updated the pipfile to reflect discord.py version 1.7.2.

You're right it says "Do not keep Pipfile.lock in version control if multiple versions of Python are being targeted". I think it'd be best if we only target a single version of python though. Python3.9 is installed on the Ubuntu server, so it shouldn't be a problem.