search

Studyxnet / FilePicker-Plugin-for-Xamarin-and-Windows

FilePicker Plugin for Xamarin and Windows
MIT License
74 stars 52 forks source link

Fixing issue with Google Drive, OneDrive on Android #52

Closed ArtjomP closed 6 years ago

ArtjomP commented 7 years ago

Bug with getting content from external content (Google Drive, OneDrive etc) has been fixed. Issues #44 #27 #24

MKuckert commented 7 years ago

Made some small changes to really fix this (see https://github.com/ArtjomP/FilePicker-Plugin-for-Xamarin-and-Windows/pull/1)

ShahriatHossain commented 7 years ago

I am getting this exception if I download this branch and replace dll files of my existing setup after building:

System.MissingMethodException: Method 'Plugin.FilePicker.Abstractions.FileData.ReadFully

can anybody help me?

ArtjomP commented 7 years ago

Hi there. I was out of my computer. Now I'm back. @ShahriatHossain it seems you forgot to added only Abstract version of the library and forgot to add Android specialization.

ShahriatHossain commented 7 years ago

@ArtjomP Thank you very much for your such a valuable response to me, can you tell me which Abstract version I should add and how to add Android specialization in my xamarin form project?

ArtjomP commented 7 years ago

@ShahriatHossain for your Android project you need to add reference to Plugin.FilePicker.dll & Plugin.FilePicker.Abstractions.dll from bin directory of Plugin.FilePicker.Android

ArtjomP commented 7 years ago

While this pull request is not merged yet I've issued nuget package Install-Package pt.Xamarin.Plugin.FilePicker -Version 1.3.6 with changes from this pull request.

golavr commented 7 years ago

The fix works perfect, good job @ArtjomP

iupchris10 commented 7 years ago

Hi there! The issue seemed to go away when I downloaded the source and compiled the code myself. I still don't have any luck with the Nuget package. But I've had several issues with the Nuget package anyway, especially with getting a NotImplementedException in CrossFilePicker. I also needed to make specific modifications to the source anyway for my specific use-case, such as allowing the user to pick ZIP files in iOS from iCloud drive, displaying the iCloud picker on the active viewmodel instead of on UiWIndow, and adding external storage permission checks in for Android for OS >= 6.0.

If I run into any more issues, I'll let you know. I might make a branch in the future to address some of the above concerns.

-Chris

On Thu, Sep 14, 2017 at 9:07 AM, ArtjomP notifications@github.com wrote:

Hi there! Have you fixed your issue? Where the problem was?

Sent from Mail for Windows 10

From: Chris Boehm Sent: Tuesday, September 12, 2017 6:16 PM To: Studyxnet/FilePicker-Plugin-for-Xamarin-and-Windows Cc: ArtjomP; Mention Subject: Re: [Studyxnet/FilePicker-Plugin-for-Xamarin-and-Windows] Fixingissue with Google Drive, OneDrive on Android (#52)

I just installed 1.3.6 and I still receive an error when trying to pick a photo from Google Drive: System.IO.DirectoryNotFoundException: Could not find a part of the path "/document/acc=1;doc=46".

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Studyxnet/FilePicker-Plugin-for-Xamarin-and-Windows/pull/52#issuecomment-329475984, or mute the thread https://github.com/notifications/unsubscribe-auth/AFe-_fPhH6DDBrr7NszpGE-9qeobNMJgks5siSUFgaJpZM4N_47K .

jfversluis commented 6 years ago

Can we get this code into the fork here: https://github.com/jfversluis/FilePicker-Plugin-for-Xamarin-and-Windows?

Since this seems abandoned (again) I've created another fork and will start pushing NuGets from there