Add direct file mover - Githubissues

StuffAnThings / qbit_manage

This tool will help manage tedious tasks in qBittorrent and automate them. Tag, categorize, remove Orphaned data, remove unregistered torrents and much much more.

MIT License

639 stars 42 forks source link

Add direct file mover #511

Open NooNameR opened 3 months ago

NooNameR commented 3 months ago

Description

Change mover logic from triggering entire move operation and just move single torrent files + links.

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] This change requires a documentation update

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have added or updated the docstring for new or existing methods
[X] I have modified this PR to merge to the develop branch

NooNameR commented 3 months ago

likely just regurgitating chatgpt code vomit

I'm not sure what you mean, by unrelated changes. All changes are completely related. If you are inclining of missing "comment", it just got lost in different re-ordering as it introduced different approach in comparison to just calling mover. As well, I did bunch of tests to polish the behavior.

I like to hear constructive feedback instead of "randomly chatgpt generated one"

NooNameR commented 3 months ago

there is still and odd case: there is can be hardlink for the torrent falling into the date range, but torrent which is using it might not - so we won't stop it before moving. (can happen with cross-seed quite easily). But this behavior exists with current mover as well

AN1MATEK commented 3 months ago

Do you think we can add an argument --mover-old instead of relying in people to comment or uncomment that line of code? I was gonna make a PR myself with this small change, but I see that you started some more important work here. It happened to me that last time I updated this script, I completely forgot about that part and got some unexpected results.

NooNameR commented 3 months ago

Do you think we can add an argument --mover-old instead of relying in people to comment or uncomment that line of code? I was gonna make a PR myself with this small change, but I see that you started some more important work here. It happened to me that last time I updated this script, I completely forgot about that part and got some unexpected results.

I'm still not sure we are gonna push this changes at all. still under some consideration