StuffAnThings / qbit_manage

This tool will help manage tedious tasks in qBittorrent and automate them. Tag, categorize, remove Orphaned data, remove unregistered torrents and much much more.
MIT License
635 stars 41 forks source link

Update mover.py: add optional arg --status-filter to allow fine tune which torrents to pauseUpdate mover.py: add optional arg --status-filter to allow fine tune which torrents to pause #599

Closed convexshiba closed 4 days ago

convexshiba commented 5 days ago

Description

add optional arg --status-filter to allow fine tune which torrents to pause useful when only wish to pause seeding torrents but not downloading ones.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

bobokun commented 5 days ago

I'm not sure I understand the use case for this. When would you want to leave a torrent unpaused when running the mover script? If a torrent is not paused then the torrent won't be able to be moved by mover if the files are in use.

convexshiba commented 4 days ago

I'm not sure I understand the use case for this. When would you want to leave a torrent unpaused when running the mover script? If a torrent is not paused then the torrent won't be able to be moved by mover if the files are in use.

The situation I run into is that if there are a significant amount of torrents still downloading, pausing them will lead all files. including unfinished ones, to be moved to disk. Then after resume qbittorrent will then continue to download directly into disk for an extended period of time.

By only limiting pausing downloading torrents, this will lead to only these to move:

These are only going to be read-only after being moved.

So this way the hard drive will host read-heavy files and writes will still be done into Cache as much as possible.

This has another, albeit minor, advantage when harddrive array writes speed are slower than cache write speed.

bobokun commented 4 days ago

okay, makes sense. Can you make the default 'completed' instead of None? I think in general most people would want to leave downloading torrents in cache like you mentioned.

convexshiba commented 4 days ago

okay, makes sense. Can you make the default 'completed' instead of None? I think in general most people would want to leave downloading torrents in cache like you mentioned.

Sure thing. I think moving "all" is still a valid use case, but it's easily changeable both ways.

seems we both changed it. not sure how to get my commit removed from PR.