WIP: rewrite to typescript - Githubissues

Stuk / jszip-utils

Other

230 stars 193 forks source link

WIP: rewrite to typescript #36

Open dartess opened 3 years ago

dartess commented 3 years ago

https://github.com/Stuk/jszip-utils/issues/34

what was done:

code rewritten to typescript
the assembly remained on browserify, because the umd generation works, and the concatenation of the license file also works, and there is also no point in rewriting the ie file.
types are generated separately because tsify cannot do this

what are the questions:

is everything okay?
jshit doesn't work with typescript. I have a few options: a) just remove jshit b) convert jshit config to eslint. at the same time, a lot of settings that go by default will be missed (only those rules that are explicitly indicated in the config will remain) c) connect any standard preset for eslint, for example airbnb or your favorite.
should i increase the version? Minor or patch?
can I add myself to the package contributors?

vtrphan commented 1 year ago

what's the status of this? i really need TS definitions. Thanks