search

Stuk / jszip-utils

Other
230 stars 193 forks source link

Features/progress #8

Closed raulsouzalima closed 5 years ago

raulsouzalima commented 9 years ago

When working with big files, it's important to have a progress callback of the downloaded file, so, this pull request implements this.

dukex commented 9 years ago

Awesome! +1

Stuk commented 9 years ago

I really like the idea, but this breaks the convention of the last argument being an errback.

Although I dislike optional arguments that aren't last, it might be best here to put the progress callback as the second argument. Alternatively we could have an options object.

I'm traveling at the moment, so I'll have to think about this some more

On March 17, 2015 9:12:24 AM PDT, Raul Souza Lima notifications@github.com wrote:

When working with big files, it's important to have a progress callback of the downloaded file, so, this pull request implements this. You can view, comment on, or merge this pull request online at:

https://github.com/Stuk/jszip-utils/pull/8

-- Commit Summary --

  • add progress callback
  • update documentation with progress callback
  • add generated files

-- File Changes --

M dist/jszip-utils.js (6) M dist/jszip-utils.min.js (2) M documentation/api/getbinarycontent.md (26) M lib/index.js (6) M test/test.js (11)

-- Patch Links --

https://github.com/Stuk/jszip-utils/pull/8.patch https://github.com/Stuk/jszip-utils/pull/8.diff

Reply to this email directly or view it on GitHub: https://github.com/Stuk/jszip-utils/pull/8

bbottema commented 9 years ago

@Stuk What happened to this?

dukex commented 9 years ago

The progress callback could be a opcional argument

Stuk commented 5 years ago

Functionality released as part of v0.1.0