Stuk / jszip

Create, read and edit .zip files with Javascript
https://stuk.github.io/jszip/
Other
9.81k stars 1.3k forks source link

Compression default should be `DEFLATE`, not `STORE` #931

Open FuzzyGamesOn opened 1 month ago

FuzzyGamesOn commented 1 month ago

(After seeing some of the comments on other issues, seems like I'm not the only person that was confused by this.)

The default value for the compression option on generateAsync should be the value that people are most likely to use. And I feel like most users seeking out a zip library would expect that the zip would be compressed by default. So having the default be STORE (no compression) seems incorrect, and like it would just confuse users.