search

Stumpii / ScintillaNET.WPF

A WPF Wrapper around the ScintillaNET v3 control
MIT License
42 stars 13 forks source link

Consider multi-targetting .NET Core and .NET Framework #9

Open fernandreu opened 4 years ago

fernandreu commented 4 years ago

Hello,

There is a method incompatibility in ScintillaNET between .NET Framework and .NET Core which means it needs to be re-targeted if .NET Core needs to be supported (see this issue). As one of my projects using ScintillaNET is also targeting both frameworks, I have gone ahead and created a ScintillaNET fork that supports multi-targeting. It is available here in GitHub and here in NuGet. ScintillaNET.WPF could also support multi-targeting if using this version of ScintillaNET instead.

Now, my project also uses ScintillaNET.WPF, currently as a slightly modified of the project embedded in my solution. However, I was planning to do the same I did with ScintillaNET: fork your repo, make the changes I need, and then release a new NuGet package.

If you are interested in multi-targeting .NET Core and .NET Framework, I could also make the changes I need directly in this repo as pull requests instead.

Regards, Fernando

fernandreu commented 4 years ago

FYI, this is now done: https://github.com/fernandreu/ScintillaNET.WPF

This also includes a few extra things I needed for my project, such as a custom automation peer to be able to interact with the control itself (e.g. know what is the text being displayed) during UI tests, and some of the properties being converted to DependencyProperty to be able to perform XAML bindings (e.g. Zoom).