search

Stunkymonkey / nautilus-open-any-terminal

GNU General Public License v3.0
568 stars 59 forks source link

Fix duplicated wezterm menu entry #133

Closed lvxnull closed 7 months ago

lvxnull commented 7 months ago

Fixes #132

Stunkymonkey commented 7 months ago

@lvxnull I am not against this, but I am a bit worried, that we add so many if/else cases, that this will be too complex someday. Your oppinion?

But overall LGTM.

PS: did not recieve a ping here, that's why I respond so late.

lvxnull commented 7 months ago

We could also just let the wezterm devs handle nautilus integration and drop wezterm support. If that's what you want I can change this PR to do that instead.

Stunkymonkey commented 7 months ago

We could. Not sure what is a good solution for this.

Maybe we go with this first solution and see where it leads.