search

Stunkymonkey / nautilus-open-any-terminal

GNU General Public License v3.0
608 stars 64 forks source link

Open Black Box Here not working #138

Closed Retch closed 9 months ago

Retch commented 9 months ago

image

Installed nautilus-open-any-terminal via pip --user. Blackbox is installed not as a flatpak and set via dconf editor.

Nothing happens when i click "Open Black Box here".

image

Retch commented 9 months ago

Close nautilus with nautilus -q and open it through a terminal. If there are any errors, send them here.

Sorry, got now what you meant.

image

image

Retch commented 9 months ago

I'm on Ultramarine (Fedora)

image This is how blackbox should be started when not installed as a flatpak

Retch commented 9 months ago

image

Retch commented 9 months ago

https://packages.fedoraproject.org/pkgs/blackbox-terminal/blackbox-terminal/

Retch commented 9 months ago

This happens because we check for fedora based only on the ID field, ignoring ID_LIKE. Soon I'll submit a PR that fixes this.

I understand, thank you :)

Stunkymonkey commented 9 months ago

i guess the distro_id string is not equal to "fedora" here, but should be: https://github.com/Stunkymonkey/nautilus-open-any-terminal/blob/master/nautilus_open_any_terminal/nautilus_open_any_terminal.py#L229

we should change it to something like: distro_id() in ["fedora", "ultramarine"]? not sure about the exact value.

Stunkymonkey commented 9 months ago

@lvxnull should we make a new release? some fixes are on master

Retch commented 9 months ago

@lvxnull Thank you very much

Stunkymonkey commented 9 months ago

@lvxnull only minor or bugfix. no breaking changes happened.