search

Stunkymonkey / nautilus-open-any-terminal

GNU General Public License v3.0
568 stars 59 forks source link

update super-linter 5 -> 6 #140

Closed Stunkymonkey closed 6 months ago

Stunkymonkey commented 7 months ago

update to the new CI workflow. see the checks.

lvxnull commented 7 months ago

Is the new version of this any faster? I hate that it tries to check every single file in the repo with a "copy paste detector" and takes a horrendously long amount of time to even start. Can't we just run black/isort/pylint ourselves instead of relying on this?

Stunkymonkey commented 6 months ago

@lvxnull new version prints the status of each linter in a separate check.

Yes we could write this our own, and yes we would forget about new linters. So to be up-to-date with linters I think this is a nice way.

lvxnull commented 6 months ago

The linters do not need to be constantly updated in order to be effective. I prefer not to spend 3 minutes waiting for a generic linter to finish checking files it does not actually understand.

If a file has been copy-pasted and passed manual code review, there is likely a valid reason for it. I do not like justifying my decisions to jscpd. Jscpd has minimal utility and depends on nodejs, which only lengthens the container startup speed.

I suggest sticking to the linters that are important to us (such as black, isort, pylint) and updating them as needed. We do not need to always be up to date just for the sake of having the latest version.

Stunkymonkey commented 6 months ago

rebased, but changed the last commit.

I totaly agree, that the linters do not need constant updates. What I really like about it: Not having to care about adding new linters for various things. But I guess we just have a different opinion on this.

If you want to we could add an additional black, pylint and isort to have faster feedback (not sure if this is in your mind; feels more like you hate the waiting-time).

Btw: The Linter is not a required Job (only the python build is). It only helps guiding.