Stunkymonkey / nautilus-open-any-terminal

GNU General Public License v3.0
595 stars 60 forks source link

have dynamic version #141

Closed Stunkymonkey closed 8 months ago

Stunkymonkey commented 8 months ago

sadly we still have the static version in pyproject.toml

The deployment then fails: https://github.com/Stunkymonkey/nautilus-open-any-terminal/actions/runs/8072181362/job/22053861823

Stunkymonkey commented 8 months ago

@lvxnull your opinion here?

Stunkymonkey commented 8 months ago

it is only a build-dependency not a normal one. So that is why I think it is not a big deal.

I did not test ist, but followed this little README: https://github.com/pypa/setuptools_scm?tab=readme-ov-file#pyprojecttoml-usage

Stunkymonkey commented 8 months ago

using the current branch results into:

[nix-shell:~/code/python/nautilus-open-any-terminal]$ git checkout 0.5.0
Note: switching to '0.5.0'.
...
HEAD is now at 26ef5f1 Merge pull request #120 from Stunkymonkey/prepare-0.5.0

[nix-shell:~/code/python/nautilus-open-any-terminal]$ python setup.py --version
0.5.0

[nix-shell:~/code/python/nautilus-open-any-terminal]$ git switch dynamic-version 
Previous HEAD position was 26ef5f1 Merge pull request #120 from Stunkymonkey/prepare-0.5.0
Switched to branch 'dynamic-version'
Your branch is up to date with 'origin/dynamic-version'.

[nix-shell:~/code/python/nautilus-open-any-terminal]$ python setup.py --version
...
0.5.2.dev5+gfbf6520

same with python -m setuptools_scm

but when downloading the packages uploaded via the CI the version states 0.1.dev1+g470e5ba.

Stunkymonkey commented 8 months ago

should be now fixed by fetching the full history.

Stunkymonkey commented 8 months ago

@lvxnull please review now