Closed Stunkymonkey closed 4 months ago
@lvxnull your opinion here?
I have mixed feelings about this. On one hand it's an extra convenience, on the other does it really warrant an extra build dependency? Also, did you test if it works?
it is only a build-dependency not a normal one. So that is why I think it is not a big deal.
I did not test ist, but followed this little README: https://github.com/pypa/setuptools_scm?tab=readme-ov-file#pyprojecttoml-usage
I ran git describe
in this project and it told me something about tags not being properly labeled as releases and to run it with --tags
instead. I'd rather not manually mark each release tag like this. Under the hood setuptools scm seems to run this command, so please make sure it works properly before we merge it.
using the current branch results into:
[nix-shell:~/code/python/nautilus-open-any-terminal]$ git checkout 0.5.0
Note: switching to '0.5.0'.
...
HEAD is now at 26ef5f1 Merge pull request #120 from Stunkymonkey/prepare-0.5.0
[nix-shell:~/code/python/nautilus-open-any-terminal]$ python setup.py --version
0.5.0
[nix-shell:~/code/python/nautilus-open-any-terminal]$ git switch dynamic-version
Previous HEAD position was 26ef5f1 Merge pull request #120 from Stunkymonkey/prepare-0.5.0
Switched to branch 'dynamic-version'
Your branch is up to date with 'origin/dynamic-version'.
[nix-shell:~/code/python/nautilus-open-any-terminal]$ python setup.py --version
...
0.5.2.dev5+gfbf6520
same with python -m setuptools_scm
but when downloading the packages uploaded via the CI the version states 0.1.dev1+g470e5ba
.
should be now fixed by fetching the full history.
@lvxnull please review now
sadly we still have the static version in
pyproject.toml
The deployment then fails: https://github.com/Stunkymonkey/nautilus-open-any-terminal/actions/runs/8072181362/job/22053861823