Closed human9 closed 4 months ago
I wouldn't mind adding this feature, but I'd rather have the local option be "open in local terminal" rather than "open in terminal" if the remote option is present as well. This would require updating the translation files.
I agree that would be preferable. I can update the code, unfortunately I am unable to translate the human languages, unless you're happy with a machine translation.
I meant that in a "this project must have the translations updated" sense, rather than "you must update the translations". I can update the Polish translation immediately after this is merged, @Stunkymonkey could update the German one, but im not sure how long it would take to get 100% translation coverage again.
I understand, in that case I'll just update the pull request to make the code changes.
Here's how right click on a remote dir now looks:
And for clicking in the background of a remote dir:
One thing I'm not sure about here is the shortcut key, I just set it to always open a local terminal but that might not be what people want.
maybe we could have a setting that determines if the keybind opens a remote terminal when possible
I see, I've replicated with hardcoded strings this time.
And a commit adding a setting that can toggle the shortcut to be local or remote. Let me know if that looks okay.
Looks ok at a first glance, I'll check more thoroughly tommorow.
Sorry for delayed response. re: length, I'm open to suggestions. One thing that would definitely reduce required code would be to accept a single naming strategy for both file and background items.
i.e., currently this is the naming for files:
Open In Remote {}
Open In Local {}
Open In {}
and for background:
Open Remote {} Here
Open Local {} Here
Open {} Here
I think the file naming scheme would work for both file and background. But maybe that could be a separate pull request.
I have an idea on how to shorten the logic of these methods, but let's focus on merging this PR first.
can you please fix the conflicts?
i will think about shortening tomorrow.
Thanks for this nice extension!
When browsing a remote location in nautilus, the native open terminal context menu option gives you the option to open a local or remote terminal:
I find this pretty useful so this pull request attempts to replicate this behavior within nautilus-open-any-terminal.
If this feature is something that you would consider merging I am happy to make any required changes. I think it could be cleaned up a bit at least.