Stunkymonkey / nautilus-open-any-terminal

GNU General Public License v3.0
590 stars 60 forks source link

add support for `vscode` #35

Closed feilongfl closed 2 years ago

feilongfl commented 2 years ago

Hi, Although project name is 'terminal', I think it's better to add some editor like vscode.

Stunkymonkey commented 2 years ago

Isn't there a file which saves the correct vscode-config which opens vscode when clicked in the folder?

problems i see:

But somehow I see your point, that the program could be more generalized. We could extend everything such, that the config contains a command. In result we execute the command with the given directory. Not really sure what to do here.

feilongfl commented 2 years ago

Previously I only searched in AUR, but did not continue my search on the web. According to https://github.com/microsoft/vscode/issues/103412, seems Nautilus-OpenInVSCode solve this problem.

About the custom command issue, I thought simpler. The custom string consists of a comma expression, which represents the program, and two sets of parameters. They are parsed at program startup.

image

Stunkymonkey commented 2 years ago

thanks for giving me the idea to generalize it. this kind of code would introduce multiple bugs, therefore i will close the issue. Additionally the value should not be only read when starting, but evaluate over and over again.