Stunkymonkey / nautilus-open-any-terminal

GNU General Public License v3.0
555 stars 55 forks source link

Support for Black Box #46

Closed not-a-dev-stein closed 2 years ago

not-a-dev-stein commented 2 years ago

I'd love to see support added for the new terminal that has been talked about in a couple of places, Black Box.

I imagine it would be troublesome to add support for it tho, considering it's the first time I'm aware of a flatpak'd terminal, I'm not sure of how hard it would be to have it work.

Stunkymonkey commented 2 years ago

sure. could you please provide the command-line options?

not-a-dev-stein commented 2 years ago

The usual one would be running flatpak run com.raggesilver.BlackBox or the more complete version the .desktop file uses, /usr/bin/flatpak run --branch=master --arch=x86_64 --command=blackbox com.raggesilver.BlackBox.

The first one would probably be the best to use tho. I hope that's what you meant by command-line options lol

Stunkymonkey commented 2 years ago

I did not explain it clearly what I wanted. Sorry. Could you please provide an example on how to run Blackbox and be in an working-directory e.g. ~/Downloads without any additional command.

Stunkymonkey commented 2 years ago

currently not supported yet. see: BlackBox-PR-9

raggesilver commented 2 years ago

Hey @Stunkymonkey, Black Box has support specifying a working directory as of a minute ago :tada:. You can do so by passing a --working-directory DIR or -w DIR for short.

With Flatpak (the only supported distribution for Black Box), the full command is flatpak run com.raggesilver.BlackBox --working-directory DIR

Usage:
  blackbox [OPTION…] [-- COMMAND ...]

Options:
  -v, --version               Show app version
  -w, --working-directory     Set current working directory
  -c, --command               Execute command in a terminal
  -h, --help                  Show help
Stunkymonkey commented 2 years ago

thanks for the update. fixed in 1ae12e1eb3cf5d8909e3e34c0043dc6cb0e7a4be

not-a-dev-stein commented 2 years ago

Am I missing something or does the implementation have some issues with the Flatpak version? Installed it as user, set Black Box as the selected terminal and it doesn't work, whilst it works fine with other terminals.

raggesilver commented 2 years ago

Does the -w parameter in BlackBox work for you?

not-a-dev-stein commented 2 years ago

Yeah, it seems to work fine if I launch Black Box through another terminal using the -w parameter.

radical4ever commented 2 years ago

now, i tried changing the parameter but it does no effect so now i guess is something related to the command used to run blackbox

polyjitter commented 2 years ago

Having issues too - looking at the commit, it doesn't look like it actually runs the flatpak command? It tries to run "blackbox" but that isn't provided by the flatpak version, which is the only official version of Black Box.

Might have to tell users to put in the flatpak run com.raggesilver.BlackBox and change that accordingly where the code refers to blackbox. Otherwise, I am unsure what another fix could be - maybe tell people to make an alias themselves?

radical4ever commented 2 years ago

maybe its worth try putting the whole command were the --working-directory patch is and reinstalling it to what happens

polyjitter commented 2 years ago

Made a pull request to fix this - #53

polyjitter commented 2 years ago

Was wondering if we could get a response for Black Box support?