Add flatpak support - Githubissues

polyjitter commented 2 years ago

Added a system for flatpak support, as flatpak versions of commands are different.

This fixes #46.

polyjitter commented 2 years ago

Doesn't actually open the working directory, not sure why. Will investigate further.

Stunkymonkey commented 2 years ago

I do not like the current approach. Please add a new gschema-option: use-flatpack.

In your exact scenario this would be fine. But this will introduce unknown behavior if it is installed locally and via flatpack.

polyjitter commented 2 years ago

Out of scope for my skills, unfortunately.

polyjitter commented 2 years ago

Spoke too soon!

polyjitter commented 2 years ago

Hey, just wanted to say that this should be finished as per your requests to modify it :)

ppvan commented 2 years ago

Does this work with blackbox yet? i tried to set to blackbox but it seems to fallback to gnome-terminal Tested on fedora 36 with blackbox 0.10.1

radical4ever commented 2 years ago

Works great!!

polyjitter commented 2 years ago

Yep! This PR should be completed, just waiting for review.

sk22 commented 2 years ago

disclaimer: i'm pretty positive that this isn't a problem of this PR, but it just occurred to me trying to switch from the user-scope pip install to the installation through setup.py.

not sure how exactly compiling the dconf schema works under the hood, but i ended up with nautilus crashing because:

Settings schema 'com.github.stunkymonkey.nautilus-open-any-terminal' does not contain a key named 'use-flatpak'

thing is, i installed nautilus-open-any-terminal first using "pip install --user" and then uninstalled it using pip (leaving the user-scoped schema in place, i guess?). now to test this fork, i ran "sudo ./setup.py install", which installed the python package system-wide and asked me to recompile the system-wide dconf schema (again, leaving the user dconf schema in place). apparently, running "glib-compile-schemas ~/.local/share/glib-2.0/schemas/" fixed this for me, output was:

No schema files found: removed existing output file.

maybe this is something setup.py should handle, @Stunkymonkey?

sk22 commented 2 years ago

Does this work with blackbox yet? i tried to set to blackbox but it seems to fallback to gnome-terminal Tested on fedora 36 with blackbox 0.10.1

it does for me!

radical4ever commented 2 years ago

maybe you need to full uninstall the old version (stunkymonkey one) and install the extension from the pull request

sk22 commented 2 years ago

maybe you need to full uninstall the old version (stunkymonkey one) and install the extension from the pull request

i did uninstall the stunkymonkey version using pip, which i assume left the dconf schema in place… actually, i just noticed i didn’t see the readme’s uninstall section, so my bad!

DeadMozay commented 2 years ago

flatpak can be used in user space, so you still need to consider the key --user

flatpak --user run com.raggesilver.BlackBox

Stunkymonkey commented 2 years ago

sorry I was on holidays without any electronic device.

I think the implementation looks good. But like DeadMozay mentioned, that supporting a user mode would be nice.

sapphic-kitten commented 2 years ago

I have reworked this PR to support flatpaks system and user mode here.

As this PR has been sitting here for quiet some time, should i open a new PR?

ppvan commented 2 years ago

I have reworked this PR to support flatpaks system and user mode here.

As this PR has been sitting here for quiet some time, should i open a new PR?

No idea..

ppvan commented 2 years ago

Any way, i have made this extension This specific for Blackbox only

Stunkymonkey commented 2 years ago

I have reworked this PR to support flatpaks system and user mode here.

As this PR has been sitting here for quiet some time, should i open a new PR?

@Klapstuhl I would appreciate you opening a new PR.

Stunkymonkey commented 2 years ago

closed via #60

Stunkymonkey / nautilus-open-any-terminal

Add flatpak support #53