search

Stunkymonkey / nautilus-open-any-terminal

GNU General Public License v3.0
555 stars 55 forks source link

Some remote connection fixes #62

Closed dolwup closed 1 year ago

dolwup commented 1 year ago

This MR fixes that the flatpak gsetting was ignored when trying to open a terminal on a remote connection as well as adds support for terminals that use a different flag (instead of -e) for being launched with a command to execute (e.g. BlackBox). I set the command flag for every terminal besides BlackBox to -e for now since I don't know which flags all of the supported terminals use (it's -efor tilix, gnome-terminal and terminator atleast)

dolwup commented 1 year ago

I was also thinking about removing "Open Remote here" since it does exactly the same as "Open here". But I'm not sure if thats not out of scope for this MR and if this is still desired to be there

Stunkymonkey commented 1 year ago

@Klapstuhl could you please test this again with flatpack? otherwise it seems ok for me.

Stunkymonkey commented 1 year ago

I did some testing today. if @Klapstuhl is not having something against it I will merge it at the weekend and release a new minor version. Thereby providing support for the new Gnome version