search

Stvad / CrowdAnki

Plugin for Anki SRS designed to facilitate cooperation on creation of notes and decks.
MIT License
520 stars 44 forks source link

Add test for repeated "import" (clone and pull) from git #150

Closed aplaice closed 2 years ago

aplaice commented 2 years ago

Diagnose #138 which occurred on Windows. (A lock for the git pack file is often held by a previous clone/pull and not released, so the next pull fails (PermissionError).)

Without the fix from #139, the test indeed fails (as expected/desired)! (See https://github.com/aplaice/CrowdAnki/pull/2.)

With the fix from #139, the test indeed succeeds (as expected/desired)! (See https://github.com/aplaice/CrowdAnki/pull/3.)

I'll leave all these PRs open for several days in case there are comments and if not, carefully merge them in the right order (fixes to tests, tests, GitHub actions?, fixes).

Edit: I added GitHub actions before the new test, to double-check that the new test fails on Windows, in the final configuration, not just with my haphazard set of commits, in the fork.

I'm not too happy with the precise implementation of this test, so I'll leave it for a couple of days, in case I can think of some improvements.